Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Nextcloud 31 and drop support for Nextcloud < 31 #390

Merged
merged 10 commits into from
Jan 21, 2025

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Oct 23, 2024

Fix #413

{
  "reqId": "Zxj0ppQQu9QyWi0XMNJWBwAAAAo",
  "level": 3,
  "time": "2024-10-23T13:05:42+00:00",
  "remoteAddr": "100.86.114.111",
  "user": "admin",
  "app": "PHP",
  "method": "POST",
  "url": "/master/index.php/login",
  "message": "Declaration of OCA\\Files_Antivirus\\AvirWrapper::file_put_contents($path, $data) must be compatible with OC\\Files\\Storage\\Wrapper\\Wrapper::file_put_contents(string $path, mixed $data): int|float|false at /home/richard/src/nextcloud/master/dev_apps/files_antivirus/lib/AvirWrapper.php#144",
  "userAgent": "[REDACTED]",
  "version": "31.0.0.3",
  "data": {
    "app": "PHP"
  }
}

@kesselb
Copy link
Contributor

kesselb commented Oct 30, 2024

I guess we need a branch off?

@st3iny
Copy link
Member Author

st3iny commented Oct 30, 2024

I guess we need a branch off?

Yeah, I think so too. We should wait until Robin is back to be sure.

@st3iny st3iny changed the title chore: fix compatibility of AvirWrapper::file_put_contents() Fix compatibility with Nextcloud 31 and drop support for Nextcloud < 30 Jan 21, 2025
@st3iny st3iny changed the title Fix compatibility with Nextcloud 31 and drop support for Nextcloud < 30 Fix compatibility with Nextcloud 31 and drop support for Nextcloud < 31 Jan 21, 2025
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
…ions

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the chore/ocp-compat branch 4 times, most recently from 97be762 to bc70720 Compare January 21, 2025 13:25
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny merged commit 28a9b6d into master Jan 21, 2025
45 checks passed
@st3iny st3iny deleted the chore/ocp-compat branch January 21, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work with NC31 Beta 3
3 participants