fix: do error on upload when a tag is not found anymore #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
|
Because it could have security implication via access control I think breaking is better? |
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
But otherwise fine by me if CI is fixed.
Member
Author
Good point. Still requires that a tag is being deleted pro-actively. Maybe an addition could be to check whether a tag is being used in a (accesscontrol) flow operation, when attempting to delete it. Both operations can be used in user as well as admin scope, might be hard to evaluate or even influence from an admin point of view. |
blizzz
force-pushed
the
fix/1211/fix-upload-deleted-tag-in-rule
branch
from
869fe55 to
e7ced62
Compare
Member
Author
|
/backport to stable32 |
- als removes a listener to CacheEntryInsertedEvent since CacheEntryUpdatedEvent will be called as well - logs a warning instead Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/1211/fix-upload-deleted-tag-in-rule
branch
from
e7ced62 to
3beb8e7
Compare
|
|
||
| #[\Override] | ||
| public function register(IRegistrationContext $context): void { | ||
| $context->registerEventListener(CacheEntryInsertedEvent::class, CacheListener::class); |
nickvergessen
approved these changes
Nov 11, 2025
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 📝 Office team
This was referenced Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1211
Example log statements:
{"reqId":"BXmsa5WqWcnyRe88EESb","level":2,"time":"2025-08-06T15:41:15+00:00","remoteAddr":"127.0.0.1","user":"spider","app":"files_automatedtagging","method":"PUT","url":"/remote.php/dav/files/spider/CanIHaz/error(2).jpeg","message":"The tag to assign (ID 77) cannot be found anymore. The related rule is owned by spider.","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:141.0) Gecko/20100101 Firefox/141.0","version":"32.0.0.1","data":{"app":"files_automatedtagging"}} {"reqId":"BXmsa5WqWcnyRe88EESb","level":2,"time":"2025-08-06T15:41:16+00:00","remoteAddr":"127.0.0.1","user":"spider","app":"files_automatedtagging","method":"PUT","url":"/remote.php/dav/files/spider/CanIHaz/error(2).jpeg","message":"The tag to assign (ID 106) cannot be found anymore. The related rule is global.","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:141.0) Gecko/20100101 Firefox/141.0","version":"32.0.0.1","data":{"app":"files_automatedtagging"}}Also comes with a little log spamming prevention, as the source events are apprently issued twice at least.