Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pdf viewer on files that have download disabled #649

Closed
juliusknorr opened this issue Aug 26, 2022 · 5 comments · Fixed by #1077
Closed

Disable pdf viewer on files that have download disabled #649

juliusknorr opened this issue Aug 26, 2022 · 5 comments · Fixed by #1077

Comments

@juliusknorr
Copy link
Member

We should not attempt to open the pdf viewer for files that have download disabled as it fails to download the file from webdav

Ref nextcloud/server#32482 (comment)

@juliusknorr
Copy link
Member Author

Related to the discussion we had @Raudius about making Collabora the default viewer in this case.

@elhananjair
Copy link

Related to the discussion we had @Raudius about making Collabora the default viewer in this case.

Oh I wish if that's possible, specially for PDF files

@juliusknorr juliusknorr moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Aug 30, 2022
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Aug 30, 2022
@juliusknorr
Copy link
Member Author

juliusknorr commented Aug 30, 2022

  • Block opening pdf files with the disabled download permission
  • Using collabora as a default just in this case is hard, as the viewer doesn't have proper logic for checking the file with custom callbacks at opening
    • We go for just registering Collabora as default for pdf if files_pdfviewer is disabled

@allexzander
Copy link

There is also an inconsistency in how "Allow download/Hide download" works with internal vs email shares. For email shares, there is a "Hide download" checkbox, which, while checked, allows the share-receiving user to view the PDF file without allowing to download it. The PDF viewer seems to be different for internal vs email share.

@strangmann
Copy link

Is there a workaround instead of using collabora? I will not switch to collabora now. The "Allow download"-function does not work anymore. Is it possible to switch to the "Hide download"-function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants