Open PDF files by default when PDF viewer is disabled #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Sep 21, 2022
lib/Capabilities.php
Outdated
|
|
||
| private $capabilities = null; | ||
|
|
||
| public function __construct(IL10N $l10n, AppConfig $config, CapabilitiesService $capabilitiesService, PermissionManager $permissionManager) { | ||
| public function __construct(IL10N $l10n, AppConfig $config, CapabilitiesService $capabilitiesService, PermissionManager $permissionManager, AppManager $appManager) { |
There was a problem hiding this comment.
Suggested change
| public function __construct(IL10N $l10n, AppConfig $config, CapabilitiesService $capabilitiesService, PermissionManager $permissionManager, AppManager $appManager) { | |
| public function __construct(IL10N $l10n, AppConfig $config, CapabilitiesService $capabilitiesService, PermissionManager $permissionManager, IAppManager $appManager) { |
Should use the IAppManager from the OCP namespace which is considered the public and stable API.
There was a problem hiding this comment.
Fixed!
Also modified my include path in PhpStorm to just include the public API, should avoid this in the future :)
juliusknorr
reviewed
Sep 21, 2022
Raudius
force-pushed
the
enh/default_pdf
branch
from
32a8e31 to
74704d1
Compare
Signed-off-by: Raul <r.ferreira.fuentes@gmail.com>
Raudius
force-pushed
the
enh/default_pdf
branch
from
74704d1 to
63842c7
Compare
juliusknorr
approved these changes
Sep 22, 2022
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable25 |
|
/backport to stable24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to nextcloud/files_pdfviewer#649