Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open PDF files by default when PDF viewer is disabled #2428

Merged
merged 1 commit into from
Sep 22, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/Capabilities.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

namespace OCA\Richdocuments;

use OCP\App\IAppManager;
use OCA\Richdocuments\Service\CapabilitiesService;
use OCP\Capabilities\ICapability;
use OCP\IL10N;
Expand Down Expand Up @@ -82,14 +83,17 @@ class Capabilities implements ICapability {
private $capabilitiesService;
/** @var PermissionManager */
private $permissionManager;
/** @var IAppManager */
private $appManager;

private $capabilities = null;

public function __construct(IL10N $l10n, AppConfig $config, CapabilitiesService $capabilitiesService, PermissionManager $permissionManager) {
public function __construct(IL10N $l10n, AppConfig $config, CapabilitiesService $capabilitiesService, PermissionManager $permissionManager, IAppManager $appManager) {
$this->l10n = $l10n;
$this->config = $config;
$this->capabilitiesService = $capabilitiesService;
$this->permissionManager = $permissionManager;
$this->appManager = $appManager;
}

public function getCapabilities() {
Expand All @@ -108,6 +112,10 @@ public function getCapabilities() {
]);
}

if (!$this->appManager->isEnabledForUser('files_pdfviewer')) {
$filteredMimetypes[] = 'application/pdf';
}

$this->capabilities = [
'richdocuments' => [
'version' => \OC::$server->getAppManager()->getAppVersion('richdocuments'),
Expand Down