Fix load of character maps #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The character maps are used by PDF.JS for font rendering, and are needed to properly show some texts (for example, Japanese text). The PDF.JS package provides the needed character maps, but the URL to get them must be set with the "PDFJS.cMapUrl" property in the same way as the "PDFJs.workerSrc" property is set (as the default value set in "viewer.js" is not right for the PDF viewer app). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
/backport to stable16 |
|
/backport to stable15 |
|
/backport to stable14 |
ChristophWurst
approved these changes
Jun 21, 2019
|
This dose fix #137, I uses the pdf to test, which mix English and Chinese. This fix resolves my problem. |
|
@leeivan Thanks a lot for testing it :-) |
|
backport to stable16 in #141 |
|
backport to stable15 in #142 |
|
backport to stable14 in #143 |
|
@ChristophWurst Mind to update the documentation with the required nginx settings? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix (but without a file to test I do not really know) #136 and #137.
The character maps are used by PDF.JS for font rendering, and are needed to properly show some texts (for example, Japanese text). The PDF.JS package provides the needed character maps, but the URL to get them must be set with the
PDFJS.cMapUrlproperty in the same way as thePDFJs.workerSrcproperty is set (as the default value set in viewer.js is not right for the PDF viewer app).