Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we only load the public script on public pages #325

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Make sure we only load the public script on public pages #325

merged 1 commit into from
Mar 17, 2021

Conversation

skjnldsv
Copy link
Member

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsv skjnldsv added this to the Nextcloud 22 milestone Feb 23, 2021
@skjnldsv skjnldsv self-assigned this Feb 23, 2021
@skjnldsv
Copy link
Member Author

/backport to stable20

@skjnldsv
Copy link
Member Author

/backport to stable21

@skjnldsv
Copy link
Member Author

/compile amend /

@nickvergessen nickvergessen removed their request for review February 23, 2021 11:23
MorrisJobke
MorrisJobke approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good 👍

@skjnldsv
Make sure we only load the public script on public pages
24d06f8 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 05168ed into master Mar 17, 2021
@skjnldsv skjnldsv deleted the fix/public branch March 17, 2021 16:29
This was referenced Mar 17, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@skjnldsv skjnldsv

Labels
4. to release enhancement
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @MorrisJobke