Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable21] Disable content copy for PDF files that specify it #417

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jun 10, 2021

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #414

@danxuliu
Copy link
Member

/compile amend /

In v2.5.207 pdf.js added the "enablePermissions" option to disable
copying in the viewer for the PDF files that specify it. The option is
off by default, so it needs to be explicitly enabled.

Note that the content copy is prevented just by disabling selection
through CSS. The "selection disabled" flag in a PDF document is not a
strong security measure and can be easily circumvented (for example,
just downloading the file and opening it in a PDF reader that does not
honour the flag), so disabling the selection through CSS was deemed good
enough for pdf.js.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the backport/414/stable21 branch from 76534d6 to c892ed6 Compare June 10, 2021 14:07
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@danxuliu danxuliu merged commit 87193fd into stable21 Jun 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the backport/414/stable21 branch June 10, 2021 14:33
@blizzz blizzz mentioned this pull request Jun 23, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant