Fixed type error with adding new retention rule #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable24 |
nickvergessen
force-pushed
the
fix-add-retention
branch
from
b46edbf to
02ed0ca
Compare
This was referenced Jul 8, 2022
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
CarlSchwan
approved these changes
Jul 8, 2022
CarlSchwan
reviewed
Jul 8, 2022
| @@ -85,7 +85,7 @@ public function run($argument): void { | |||
| // Validate if tag still exists | |||
| $tag = $argument['tag']; | |||
| try { | |||
| $this->tagManager->getTagsByIds($tag); | |||
| $this->tagManager->getTagsByIds((string) $tag); | |||
There was a problem hiding this comment.
should this maybe also be done in the createNamedParameter call? or once line 86
There was a problem hiding this comment.
No, because the retention code is int based. Only the TagManager code is string based although it casts to int afterwards itself as the DB is int for oc_systemtags* tables as well...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repushing #174 so CI runs
Fix #175
Fix #172