Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

fix-right-click multiselect in trash bin #157

Merged
merged 1 commit into from
Mar 23, 2023
Merged

fix-right-click multiselect in trash bin #157

merged 1 commit into from
Mar 23, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Mar 19, 2023 •
edited
Loading

Fix #141

Before After
image image
For my own testing 
docker run -it \
--name nextcloud-easy-test \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.24.128 \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
-e SERVER_BRANCH=master \
-e RIGHTCLICK_BRANCH=enh/noid/fix-trash-bin-multiselect \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen
fix-right-click multiselect in trash bin
c39c20d 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added the 2. developing Work in progress label Mar 19, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Mar 19, 2023
@szaimen szaimen added 3. to review Waiting for reviews bug Something isn't working and removed 2. developing Work in progress labels Mar 19, 2023
@szaimen szaimen marked this pull request as ready for review March 19, 2023 00:49
@szaimen szaimen requested a review from Pytal March 19, 2023 00:50
@szaimen
Copy link
Contributor Author

szaimen commented Mar 19, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Mar 19, 2023

/backport to stable25

@szaimen
Copy link
Contributor Author

szaimen commented Mar 19, 2023

/backport to stable24

@szaimen szaimen mentioned this pull request Mar 19, 2023
Closed
9 tasks
@szaimen szaimen requested a review from artonge March 20, 2023 09:41
artonge
artonge approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but please use English in screenshots. Easier to understand what's happening :)

@szaimen
Copy link
Contributor Author

szaimen commented Mar 20, 2023

Nice, but please use English in screenshots. Easier to understand what's happening :)

Thanks for the approval and sorry for the screenshots. My browser used german by default...

@szaimen
Copy link
Contributor Author

szaimen commented Mar 23, 2023

CI failure unrelated

@szaimen szaimen merged commit fc3a0c8 into master Mar 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/fix-trash-bin-multiselect branch March 23, 2023 13:14
This was referenced Mar 23, 2023
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
Nextcloud 27
2 participants
@szaimen @artonge