[stable16] Change name from 'Text editor' to 'Plain text editor' to prevent confusion with 'Text'

[backportbot-nextcloud]

backport of #165

[jancborchardt]

I’m a bit worried the "Edit in plain text editor" will be slightly long in the menu. Maybe we should use "Edit plain text"?

(But also, this will only show up when you have both the Text app and files_texteditor installed, right?)

[juliusknorr]

I’m a bit worried the "Edit in plain text editor" will be slightly long in the menu. Maybe we should use "Edit plain text"?

The thing here is that the new editor also supports editing plain text. Did we decide yet if we ship the files_texteditor with 17? If not, it should be fine by default, since there is only text installed then.

(But also, this will only show up when you have both the Text app and files_texteditor installed, right?)

Correct.

[jancborchardt]

Did we decide yet if we ship the files_texteditor with 17?

I guess not, since Text can do everything and more. @rullzer @MorrisJobke can you confirm?

[rullzer]

Trouble is I think that even if we do not ship it it will still stay enabled on the users that upgrade.

So not shipping is fine but doesn't solve the issue currently.

[jancborchardt]

Is there something that we can do about that? Either in server or in the Text app?

Cause having this extra menu entry for all existing users is quite a bit of a nuisance.

[juliusknorr]

@rullzer Since the files_texteditor is not shipped anymore, shouldn't it be removed from the apps directory during the update?

[MorrisJobke]

Trouble is I think that even if we do not ship it it will still stay enabled on the users that upgrade.

So not shipping is fine but doesn't solve the issue currently.

It should be removed by the updater, because it removes everything from the shipped.json. ;)

[rullzer]

@MorrisJobke but files_texteditor is no longer shipper right...

[MorrisJobke]

@MorrisJobke but files_texteditor is no longer shipper right...

That is the plan for 17, yes.

[rullzer]

@MorrisJobke yes so if it is no longer shipped then it won't be in shipped.json and thus it won't be removed on upgrade. So it will just stay installed for users.

[MorrisJobke]

@MorrisJobke yes so if it is no longer shipped then it won't be in shipped.json and thus it won't be removed on upgrade. So it will just stay installed for users.

It will be removed, because the old shipped.json is used to remove everything. Otherwise we would never be able to delete any file. 😉

[rullzer]

aaaah
perfect then.

[MorrisJobke]

aaaah
perfect then.

Seems to not work: https://drone.nextcloud.com/nextcloud/updater/181/11/2

2019-07-22T08:40:06+00:00 UnexpectedValueException: The files of the app "files_texteditor" were not correctly replaced before running the update

😢

[juliusknorr]

Hm, ok I just checked the update and the folder was removed properly but the app is still marked as enabled in the appconfig table.

@MorrisJobke Should we add a repair step to disable it automatically or maybe just make sure to disable apps automatically when there is no app folder found?

[juliusknorr]

Didn't we do the same with the user_external app? Was this an issue back then as well?

[MorrisJobke]

Didn't we do the same with the user_external app? Was this an issue back then as well?

Good question. There we replaced it with a version from the App Store AFAIK.

[juliusknorr]

Ah so the app was automatically updated since the app store had a newer version that was compatible with the new server release then?

[MorrisJobke]

Ah so the app was automatically updated since the app store had a newer version that was compatible with the new server release then?

I think so

[georgehrke]

/compile fixup /