Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only show the wizard when any slides are configured (this is the default) #1106

Closed
wants to merge 1 commit into from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 26, 2024

Only show the wizard and the "about" menu entry if any slides are configured to be shown.

This also fixes deprecation warning when using IConfig::getAppValue by switching to IAppConfig.

… default)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/only-show-if-slides-configured branch from f4a130d to 3e9b16b Compare February 26, 2024 18:00
@susnux
Copy link
Contributor Author

susnux commented Feb 26, 2024

BTW nowadays this is only an option to disable the wizard as we no longer use the slides variables -> the app is more ore less frontend only.

Meaning we could also just drop the controller and just add a "wizard enabled" option.

@szaimen
Copy link
Collaborator

szaimen commented Feb 27, 2024

BTW nowadays this is only an option to disable the wizard as we no longer use the slides variables -> the app is more ore less frontend only.

Meaning we could also just drop the controller and just add a "wizard enabled" option.

Sounds good 👍

@susnux susnux closed this Feb 28, 2024
@susnux susnux deleted the fix/only-show-if-slides-configured branch February 28, 2024 10:39
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show menu item if slides are disabled
2 participants