Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate personal setting page to vue #1259

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Migrate personal setting page to vue #1259

merged 3 commits into from
Aug 8, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 17, 2024

The page was using a removed script, so I ported it to vue completly.
But maybe this better belongs to server core?

@susnux susnux added this to the Nextcloud 30 milestone Jun 17, 2024
@susnux susnux requested review from Pytal and szaimen June 17, 2024 11:43
@susnux susnux force-pushed the fix/personal-settings branch from 6495c8e to d8c0daa Compare June 17, 2024 11:46
szaimen
szaimen reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it looks mostly fine but I noticed two things:

  • the icon has the wrong color
  • the server address does not seem to be correct

image

This was referenced Jul 30, 2024
Merged
Merged
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
Merged
@susnux susnux force-pushed the fix/personal-settings branch 2 times, most recently from d77405e to 9a67218 Compare August 6, 2024 14:26
@susnux susnux requested a review from szaimen August 6, 2024 14:30
@Altahrim Altahrim mentioned this pull request Aug 7, 2024
Merged
@szaimen
Copy link
Collaborator

szaimen commented Aug 7, 2024

I just tested this again.

  • the icon has the wrong color

This is still the case but the other issue seems to be fixed :)

However this button does not seem to work:
image

@susnux susnux force-pushed the fix/personal-settings branch from 9a67218 to 2b25d8e Compare August 7, 2024 13:47
@susnux
Copy link
Contributor Author

susnux commented Aug 7, 2024

@szaimen both issues should be now resolved

szaimen
szaimen approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested again and works :)
But didnt review the code

@susnux
refactor: Only build one CSS file for the app to prevent loading issues
3d6d70e 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/personal-settings branch from 2b25d8e to da7c782 Compare August 8, 2024 10:31
susnux added 2 commits August 8, 2024 12:33
@susnux
fix: Migrate personal settings to Vue
8285f84 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
8214741 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/personal-settings branch from da7c782 to 8214741 Compare August 8, 2024 10:34
@susnux
Copy link
Contributor Author

susnux commented Aug 8, 2024

/backport to stable29

@susnux susnux merged commit 12d14f6 into master Aug 8, 2024
43 checks passed
@susnux susnux deleted the fix/personal-settings branch August 8, 2024 11:12
@backportbot backportbot bot mentioned this pull request Aug 8, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Could not find resource firstrunwizard/js/personalsettings.js to load
2 participants
@susnux @szaimen