Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable social recommendation #692

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Apr 8, 2022

Close nextcloud/server#31883

Signed-off-by: szaimen szaimen@e.mail.de

Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen
Copy link
Collaborator Author

szaimen commented Apr 8, 2022

/backport to stable23

@szaimen
Copy link
Collaborator Author

szaimen commented Apr 8, 2022

/backport to stable22

@szaimen szaimen requested a review from Pytal April 8, 2022 17:29
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment to explain reasoning?

@szaimen
Copy link
Collaborator Author

szaimen commented Apr 8, 2022

Add a comment to explain reasoning?

I think I'll rather leave that out as I am not so sure what to write there...


cc @AndyScherzinger please merge when you are fine with this PR. Thanks! :)

@AndyScherzinger AndyScherzinger merged commit 3ced0ed into master Apr 8, 2022
@AndyScherzinger AndyScherzinger deleted the enh/noid/disable-social-recommendation branch April 8, 2022 21:02
@AndyScherzinger
Copy link
Member

@Pytal the reasoning is that we currently focus on other areas and apps thus promoting an app that is currently not working with 22+ should be prevented.

@AndyScherzinger
Copy link
Member

Thanks @szaimen 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Being clear about Social
3 participants