Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade @nextcloud/vue from 5.4.0 to 7.5.0 #815

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Upgrade @nextcloud/vue from 5.4.0 to 7.5.0 #815

merged 1 commit into from
Jan 27, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 27, 2023 •
edited
Loading

Upgrade https://github.com/nextcloud/nextcloud-vue + adapt markup

Fix "Maximum call stack size exceeded" error from focus-trap when opening from menu entry

Related

@Pytal
Upgrade @nextcloud/vue from 5.4.0 to 7.5.0
cb1cce7 
- Update markup
- Remove dropped props

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 26 milestone Jan 27, 2023
@Pytal Pytal self-assigned this Jan 27, 2023
@Pytal
Copy link
Member Author

Pytal commented Jan 27, 2023

/backport to stable25

This was referenced Jan 27, 2023
Merged
Merged
@nickvergessen nickvergessen removed their request for review January 27, 2023 06:08
szaimen
szaimen reviewed Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my testing. However the left arrow is not usable with keyboard-enter. (it brings you not to the former slide back and instead displays the same slide again).

Click do expand

image

@Pytal
Copy link
Member Author

Pytal commented Jan 27, 2023

Works in my testing. However the left arrow is not usable with keyboard-enter. (it brings you not to the former slide back and instead displays the same slide again).

Fixed in nextcloud-libraries/nextcloud-vue#3690

szaimen
szaimen approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then for now if it gets fixed in a follow-up

@Pytal Pytal merged commit c34f3a1 into master Jan 27, 2023
@Pytal Pytal deleted the deps/nextcloud/vue-7.5.0 branch January 27, 2023 22:56
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 27, 2023
Merged
1 task
@Pytal
Copy link
Member Author

Pytal commented Jan 27, 2023 •
edited
Loading

LGTM then for now if it gets fixed in a follow-up

Let's do a bump after the fix is released then

Tracking in #831

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@Pytal Pytal mentioned this pull request Feb 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
4. to release accessibility enhancement
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
2 participants
@Pytal @szaimen