-
Notifications
You must be signed in to change notification settings - Fork 58
Move actions from top to bottom, next to filename #80
Comments
From @jancborchardt on September 15, 2015 17:8 (I’m not sure yet about the text next to the Download icon, if it’s really necessary. What do you think @oparoz @owncloud/designers?) |
From @stefan-niedermann on September 15, 2015 17:19 what about linking the filename with the download action? is there already another action on the filename? |
From @deMattin on September 15, 2015 17:26 By clicking on filename I won't expect a download. I think, this is no usual behaviour for that. @jancborchardt: Probably there will come some more icons in future (rotate is a MUST have!), and so there should be no text next to the button. |
Hmmm... it works with the download button and probably with other "file actions" because the filename gives the proper context, but I think I'll keep the brightness button at the top and will probably convert it into a shades scale if there is nothing else to add... And I think it should be meaningful icons only, no text, because there is not that much space available. |
Ah yes, rotate. That's another example of icon I would see at the top with brightness. |
From @jancborchardt on September 15, 2015 17:35
Yup. So @oparoz can you move the download icon there? |
Well, it's not all over the place, but we shall test. When there was no filename, you would miss the icons if not careful. The eye is drawn to the top. |
From @jancborchardt on September 15, 2015 17:49 The eye is drawn to the image. And even if it is drawn to the top, that’s another reason why the actions should be at the bottom. Because otherwise they will distract from the image. |
Maybe you're right, if the user has an issue, he will look for solutions and will hopefully notice the icons at the bottom. |
From @enoch85 on September 15, 2015 19:4 Would be nice to move all the actions to the bottom except X (close). Here is an example in Pydio, not as clean as ownCloud though: |
Also note how we can easily read the caption as opposed to how difficult it is to read the filename in the pic in the OP. |
From @enoch85 on September 15, 2015 21:20 +1 for Photoswipe. But I still think the actions should be on the bottom. @jancborchardt is on to something good here. And also, for white pictures the arrows are hard to see. |
From @jancborchardt on September 15, 2015 22:18
@oparoz sorry but no – we have a release upcoming very soon. Things just need to be done now. I don’t just make these designs up from the top of my head. |
@jancborchardt Even the best thought out designs need to be tested. Users are surprising.
http://www.joelonsoftware.com/articles/fog0000000043.html But in any case, I think both approaches would work. Can we have a mock up with a long filename (30+ chars) and a few icons? edit, download, share, rotate and brightness? |
From @jancborchardt on September 15, 2015 23:42 @oparoz no need to tell me that … I studied it and work in the field since many years. We currently only have download, so only the download icon needs to be there. When more actions come there, we will do 2 things: 1) ellipsize the filename and 2) introduce a dot-dot-dot more menu like in files. Especially for rotate, rename and brightness which don’t always need to be there. The only actions which need to be visible always are Favorite, Share and maybe Download. |
OK, makes sense. |
From @jancborchardt on September 15, 2015 23:51 Cool. |
From @enoch85 on September 15, 2015 23:59 Very cool. Will this be in 8,2? |
From @deMattin on September 16, 2015 7:40 I definitly agree with the "..." menu solution for rarely used actions. I know, this is the "I share everything" generation, but gallery is primary a viewer and it's possible, that you have many pictures in gallery, that aren't well orientated (I recently got one shared) and so it will be very frustrating to access a menu to rotate every 2nd or 3rd picture by viewing the pictures. But I also know, that sharing can be directly accessed in any owncloud app and so it probably should be also present here - although I don't go with this "share-mania" ... ;) So in my point of view "download" and "rotate" are the two actions that definitly have to get separate action buttons! |
From @jancborchardt on September 16, 2015 7:58
Sorry, but rotation is not that much of a common action to be shown directly. Any of those arguments could possibly be done for any action, and if we would show every action directly then it would be a clusterf$%k of icons again. Hence, I’d say rotate could get a shortcut (adapt from common photo software and what they use for rotating). I guess that will solve your problem @deMattin.
Yeah, but remember – you or I are not the only ones we design this product for. Again: The actions which should be permanently visible are Favorite (left of filename as star), Share, and Download. Rest goes into the more menu. And actually Download should only show there directly (instead of the more menu) for public shares, not when you are logged in to your own ownCloud where, well, you already have all the files downloaded. |
From @deMattin on September 16, 2015 9:11 @jancborchardt: Sorry, you didn't get the point "sharing will never be comfortable in gallery view" and because of THIS noone will often use it in gallery view on many pictures. But I really don't understand, why you don't see rotation as the most important action. Look at a photo and if it is not orientated right, correct this (or twist your neck).
If you have only well orientated pictures and so never use rotation, it's your personal opinion, that rotation is not needed! Please mind your attitude. And a shortcut is no solution, because you have to learn it. This would surely solve it to me but not for the "normal" user using intuitive GUI for anything. With the download button I don't agree, too |
From @jancborchardt on September 16, 2015 9:43 @deMattin the problem with the whole thing is that this discussion is completely derailed. The topic this is about, and what we need to fix for 8.2, is that Download should be at the bottom next to the filename instead of at the top.
Because, well, it’s different. You can obviously also not delete files from a read-only shared folder, whereas you can do that in your own one. |
From @deMattin on September 16, 2015 10:19 Agree to close rotation button discussion here and get focus on release topic. For download I gave you the example - which is a common usecase - that you need to download a single picture from your signed in own cloud. I can imagine many usecases, where this could happen and is useful. And ... I already use it sometimes in such a way when I log in on other PC, on work or with tablet! Deleting pictures in shared gallery is no topic and I agree to hide buttons, that don't work in shared galleries. But the download button IS working and useful also for your signed in own cloud. |
From @jancborchardt on September 16, 2015 11:23
So there’s a misunderstanding. I’m not talking about hiding the function altogether and having it only in the files view. What I’m saying is that in the slideshow view, next to the directly visible actions like download, there should be an icon |
I'll let you move all your buttons arguments to this new "thread": owncloud/gallery#351 After testing buttons at the bottom, I vote against it. It doesn't work on small screens, in portrait mode. Even if you only keep the filename and the 3 dots, you have everything squeezed against each other center-right, but plenty of space at the top. |
From @jancborchardt on September 23, 2015 20:21 @oparoz the file list does it exactly like it: filename, share action, 3 dots. In addition it has favorites and the preview on the left, so there’s plenty of space for the play/pause action and even showing the download option directly. Please do this for 8.2 – having the Download action at the top clutters controls all over. |
Yes, but that's in a row, with lots of information organised in columns.
Yes, if that doesn't work at the bottom, it should definitely be pushed back to the right, like on some of the slideshows we've been studying. We could also imagine moving play/pause up there in order to avoid having any controls at the bottom. My remaining issues with having everything at the bottom:
|
We need static mock ups to understand better how things will look. |
If that's too much work for 8.2, I can definitely move the top buttons to the right and give them the same size, as a quick fix. |
From @jancborchardt on September 25, 2015 20:18 @oparoz I made a mockup above 10 days ago. And also mentioned the importance of this before. Please fix this for 8.2 – the controls should be next to the filename. cc @owncloud/designers @karlitschek |
From @jancborchardt on September 25, 2015 20:19 And at the moment it’s the download action only anyway. We can do more specific mockups in the 9.0 dev cycle. Rest assured it will fit, because it works for the filelist too. |
From @cmonteroluque on October 1, 2015 20:7 This issue will fall off 8.2 if not resolved by 6 Oct |
From @jancborchardt on October 5, 2015 5:43 (I’m on vacation, this is an exception.) @oparoz It’s really a bit unfortunate that we can’t get this simple moving of the action down next to the filename done. What’s so complicated about simply moving it there? It’s only the download action, as I said. If assistance is required cc @MorrisJobke @PVince81 @Henni |
There are 2 icons. One of them is optional, but it will still show up for some users. So I have dilemma and don't want to go back and forth, so I'm more in favour of keeping the icons top right for now (I don't think centre top works that well), like we've seen on some competitive products and move things to the bottom, once it's proven that it's a better, fully tested alternative. I think I need to email you to talk about some details... |
From @jancborchardt on October 6, 2015 21:44
No, but we could consider for example showing some more options in the three dots menu on mobile. Like Download – and the Background switcher for sure. That would only leave the star and the three dots. |
From @jancborchardt on December 16, 2015 15:56 This is basically a sub-issue of owncloud/gallery#68 |
Superseded by #540 |
From @jancborchardt on September 15, 2015 17:7
We shouldn’t have actions in every corner and on every edge. The actions possible with the file should be next to the filename, on the bottom:
@oparoz can you do that? :) I can do styling fixes if needed.
(Also yeah, I will make it so that the action icons work for light images as well – currently working on that. :)
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Copied from original issue: owncloud/gallery#349
The text was updated successfully, but these errors were encountered: