Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a share button (and other actions like delete, rename) to the large preview [$5] #68

Closed
3 tasks
oparoz opened this issue Mar 7, 2015 · 8 comments
Closed
3 tasks

Comments

@oparoz
Copy link
Contributor

oparoz commented Mar 7, 2015

We already have download, maybe it would be useful to have a "share" button there as well?
Clicking on it would reveal the usual dropdown and let people share that one picture via the usual means.

It's something I've seen on other slideshows, but I have no idea if this is really needed or if people would rather share the entire folder like it is now.

Next steps

There is a share API, but using it in this app just means re-inventing the wheel, so we should use whatever is used in core and theme it

There is a $5 open bounty on this issue. Add to the bounty at Bountysource.

@deMattin
Copy link

It could be usefull in some (rare) situations - but normally I share single files from file app.
You tagged for user experience? I don't need this!
But it won't annoy me, if it would be there.

@oparoz
Copy link
Contributor Author

oparoz commented Mar 14, 2015

It's all about making the life of users easier. You're in full screen mode and you see something you want to share, you don't want to have to quit the slideshow, go to Files, find the file and click share.

@jancborchardt
Copy link
Member

Yes – all actions which are available in the files list should also be available in the detail view. However (as I think I said in another issue as well) instead of bulky buttons up top, as nice grey text+icons on the bottom center. :)

@oparoz oparoz added the On hold label May 17, 2015
@oparoz oparoz added the v8.2 label May 22, 2015
@oparoz oparoz changed the title Add a share button to the large preview Add a share button to the large preview [$5] Jun 21, 2015
@oparoz oparoz added the bounty label Jun 21, 2015
@oparoz oparoz mentioned this issue Jul 29, 2015
12 tasks
@jancborchardt jancborchardt changed the title Add a share button to the large preview [$5] Add a share button (and other actions like delete, rename) to the large preview [$5] Dec 16, 2015
@jancborchardt
Copy link
Member

Moving the actions from up top to a proper place is prerequisite for this: #349

Also to fix the confusion: #474

@jospoortvliet
Copy link

Add commenting! for 9.0 ;-)

@jancborchardt
Copy link
Member

@jospoortvliet different issue ;) #176

@oparoz
Copy link
Contributor Author

oparoz commented Mar 1, 2016

Once we have a sidebar, we should be able to use the core share dialogue
https://github.com/owncloud/core/blob/master/core/js/sharedialogview.js

and get rid of our old share.js

@oparoz
Copy link
Contributor Author

oparoz commented Sep 4, 2016

This issue was moved to nextcloud/gallery#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants