Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not store group folders inside user data directory #338

Closed
leonklingele-work opened this issue Mar 6, 2019 · 1 comment · Fixed by nextcloud/server#26137
Closed

Do not store group folders inside user data directory #338

leonklingele-work opened this issue Mar 6, 2019 · 1 comment · Fixed by nextcloud/server#26137
Labels
1. to develop Issues that are ready for development bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. high high priority

Comments

@leonklingele-work
Copy link

Do not store group folders inside the Nextcloud user directory under user name __groupfolders .
This makes it possible to delete all data associated with a group folder if a user __groupfolders decides to delete his account (for example using the drop_account app).
@pierreozoux pierreozoux added 0. Needs triage Issues that need to be triaged bug high high priority labels Mar 14, 2021
@pierreozoux
Copy link
Member

Maybe a good workaround would be to forbid __groupfolders username? This would be an easy fix without much impact..

@pierreozoux pierreozoux added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 1. to develop Issues that are ready for development and removed 0. Needs triage Issues that need to be triaged labels Mar 14, 2021
icewind1991 added a commit to nextcloud/server that referenced this issue Mar 15, 2021
@icewind1991
dont allow creating users with __groupfolders as uid
084df0e 
Fixes nextcloud/groupfolders#338

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 mentioned this issue Mar 15, 2021
Merged
icewind1991 added a commit to nextcloud/server that referenced this issue Mar 16, 2021
@icewind1991
dont allow creating users with __groupfolders as uid
dd477d3 
Fixes nextcloud/groupfolders#338

Signed-off-by: Robin Appelman <robin@icewind.nl>
backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Mar 16, 2021
@icewind1991 @backportbot
dont allow creating users with __groupfolders as uid
1089d85 
Fixes nextcloud/groupfolders#338

Signed-off-by: Robin Appelman <robin@icewind.nl>
backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Mar 16, 2021
@icewind1991 @backportbot
dont allow creating users with __groupfolders as uid
279f0d7 
Fixes nextcloud/groupfolders#338

Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Issues that are ready for development bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. high high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dont allow creating users with __groupfolders as uid nextcloud/server
2 participants
@pierreozoux @leonklingele-work