preventDefault on folder create submit event #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when navigating to the group folders settings and pressing create, it will triger the form submit navigation to `settings/admins/groupfolders#?`. Once you're at the url with `#` the form submit will no longer triger a page nagivation. Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
create-prevent-default
branch
from
05e1846 to
725ddd0
Compare
juliusknorr
approved these changes
Mar 29, 2021
|
/backport to stable21 |
|
/backport to stable20 |
|
/backport to stable19 |
|
The backport to stable21 failed. Please do this backport manually. |
This was referenced Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when navigating to the group folders settings and pressing create, it will triger the form submit navigation to
settings/admins/groupfolders#?.Once you're at the url with
#the form submit will no longer triger a page nagivation.Signed-off-by: Robin Appelman robin@icewind.nl