Skip to content

Dispatch audit event when changing ACL rules #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2022
Merged

Dispatch audit event when changing ACL rules #1917

merged 1 commit into from
Mar 14, 2022

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Mar 4, 2022

Implements #1744

@CarlSchwan CarlSchwan added the 3. to review Items that need to be reviewed label Mar 4, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 24 milestone Mar 4, 2022
@CarlSchwan CarlSchwan requested a review from PVince81 March 4, 2022 13:56
@CarlSchwan CarlSchwan self-assigned this Mar 4, 2022
This was referenced Mar 4, 2022
Merged
Closed
PVince81
PVince81 reviewed Mar 4, 2022
View reviewed changes
PVince81
PVince81 reviewed Mar 4, 2022
View reviewed changes
PVince81
PVince81 reviewed Mar 4, 2022
View reviewed changes
@CarlSchwan CarlSchwan force-pushed the feat/audit_log branch 2 times, most recently from ae2d74e to 65e314a Compare March 7, 2022 10:13
PVince81
PVince81 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

would be good to also add a unit test that catches the event and checks at least the params, I think we did this in other places

@CarlSchwan
Dispatch audit event when changing ACL rules
11c7ebc 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan merged commit 51574d3 into master Mar 14, 2022
@CarlSchwan CarlSchwan deleted the feat/audit_log branch March 14, 2022 15:44
@CarlSchwan
Copy link
Member Author

CarlSchwan commented Mar 15, 2022

/backport to stable23

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 15, 2022
Merged
@CarlSchwan
Copy link
Member Author

CarlSchwan commented Mar 15, 2022

/backport to stable22

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 15, 2022
Merged
@joshtrichards joshtrichards mentioned this pull request Sep 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review Items that need to be reviewed

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

3 participants

@CarlSchwan @PVince81