Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adapt return type for Nextcloud 26 #2262

Merged
merged 4 commits into from
Feb 14, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 8, 2023

@juliusknorr juliusknorr added bug 3. to review Items that need to be reviewed labels Feb 8, 2023
@come-nc
Copy link
Contributor

come-nc commented Feb 8, 2023

ERROR: InvalidReturnType - lib/ACL/ACLStorageWrapper.php:235:35 - The declared return type 'false|int' for OCA\GroupFolders\ACL\ACLStorageWrapper::filesize is incorrect, got 'bool|int' (see https://psalm.dev/011)
	public function filesize($path): false|int|float {

ERROR: InvalidReturnStatement - lib/ACL/ACLStorageWrapper.php:239:10 - The inferred type 'bool|int' does not match the declared return type 'false|int' for OCA\GroupFolders\ACL\ACLStorageWrapper::filesize (see https://psalm.dev/128)
		return parent::filesize($path);

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/wrapper-return-type branch from 031ca9d to cb4cf17 Compare February 13, 2023 07:00
@march42
Copy link
Contributor

march42 commented Feb 13, 2023

This fixes issue #2264 on my test instance and makes beta3 usable. @nursoda

@nursoda
Copy link

nursoda commented Feb 13, 2023

@march42 Thanks for the hint! I just verified, it also does fix the issue for me. After modifying the three files accordingly, and re-activating groupfolders, all works fine and I see no error messages in nextcloud.log.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr merged commit d817a22 into master Feb 14, 2023
@juliusknorr juliusknorr deleted the bugfix/noid/wrapper-return-type branch February 14, 2023 17:04
@nursoda
Copy link

nursoda commented Feb 21, 2023

In NC 26 beta4 I get errors again. I've documented them in my initial issue report #2264.

@come-nc
Copy link
Contributor

come-nc commented Feb 23, 2023

In NC 26 beta4 I get errors again. I've documented them in my initial issue report #2264.

Yes because there was no new release of groupfolders application yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants