Skip to content

fix: ensure options is always an array #4011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Sep 27, 2025
Merged

fix: ensure options is always an array #4011

provokateurin merged 1 commit into from
Sep 27, 2025

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 23, 2025

Fix #4009

@kesselb kesselb self-assigned this Sep 23, 2025
@kesselb kesselb added bug 3. to review Items that need to be reviewed labels Sep 23, 2025
solracsf
solracsf reviewed Sep 23, 2025
View reviewed changes
come-nc
come-nc requested changes Sep 25, 2025
View reviewed changes
@kesselb
fix: ensure options is always an array
c2953e8 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the bug/4009/handle-null-json-decode branch from e09016d to c2953e8 Compare September 25, 2025 09:31
@provokateurin provokateurin merged commit 189fc98 into master Sep 27, 2025
68 of 84 checks passed
@provokateurin provokateurin deleted the bug/4009/handle-null-json-decode branch September 27, 2025 17:54
@come-nc
Copy link
Contributor

come-nc commented Sep 29, 2025

/backport stable32

@come-nc come-nc mentioned this pull request Sep 29, 2025
Closed
@MichaIng
Copy link
Member

MichaIng commented Sep 29, 2025

/backport to stable32

@backportbot backportbot bot mentioned this pull request Sep 29, 2025
Merged
@come-nc
Copy link
Contributor

come-nc commented Sep 29, 2025

(31 does not have the method so does not need the fix I think)

@ollimaz
Copy link

ollimaz commented Oct 1, 2025

(31 does not have the method so does not need the fix I think)

I disagree I've got the same issues after updating to 19.1.7

@MichaIng
Copy link
Member

MichaIng commented Oct 1, 2025 •
edited
Loading

I disagree I've got the same issues after updating to 19.1.7

Please compare the error messages carefully. This PR fixes

TypeError: json_decode(): Argument #1 ($json) must be of type string, null given in PATH/apps/groupfolders/lib/Folder/FolderManager.php

as reported here: #4037

This cannot appear on app versions below 20, i.e. not on Nextcloud 31 or lower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solracsf solracsf solracsf left review comments

@icewind1991 icewind1991 icewind1991 approved these changes

@provokateurin provokateurin provokateurin approved these changes

@come-nc come-nc come-nc approved these changes

Assignees

@kesselb kesselb

Labels

3. to review Items that need to be reviewed bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Master: json_decode(): Argument #1 ($json) must be of type string, null given"

8 participants

@kesselb @come-nc @MichaIng @ollimaz @icewind1991 @solracsf @provokateurin