fix(DirMask): Fix return types

Signed-off-by: provokateurin <kate@provokateurin.de>
nextcloud · Oct 1, 2024 · 86d0107 · 86d0107
1 parent 3825770
commit 86d0107
Show file tree

Hide file tree

Showing 2 changed files with 165 additions and 109 deletions.
diff --git a/lib/Storage/DirMask.php b/lib/Storage/DirMask.php
@@ -22,6 +22,7 @@
 namespace OCA\Guests\Storage;
 
 use OC\Files\Storage\Wrapper\PermissionsMask;
+use OCP\Files\Cache\ICache;
 
 /**
  * While PermissionMask can mask a whole storage this  can
@@ -100,9 +101,6 @@ public function getPermissions($path): int {
 		}
 	}
 
-	/**
-	 * @psalm-suppress ParamNameMismatch
-	 */
 	public function rename($source, $target): bool {
 		if (!$this->isUpdatable($source)) {
 			return false;
@@ -123,9 +121,6 @@ public function rename($source, $target): bool {
 		return false;
 	}
 
-	/**
-	 * @psalm-suppress ParamNameMismatch
-	 */
 	public function copy($source, $target): bool {
 		if (!$this->isReadable($source)) {
 			return false;
@@ -162,10 +157,7 @@ public function mkdir($path): bool {
 		}
 	}
 
-	/**
-	 * @psalm-suppress MethodSignatureMustProvideReturnType
-	 */
-	public function rmdir($path) {
+	public function rmdir($path): bool {
 		if ($this->checkPath($path)) {
 			return parent::rmdir($path);
 		} else {
@@ -181,20 +173,14 @@ public function unlink($path): bool {
 		}
 	}
 
-	/**
-	 * @psalm-suppress MethodSignatureMustProvideReturnType
-	 */
-	public function file_put_contents($path, $data) {
+	public function file_put_contents($path, $data): int|float|false {
 		if ($this->checkPath($path)) {
 			return parent::file_put_contents($path, $data);
 		} else {
 			return $this->storage->file_put_contents($path, $data);
 		}
 	}
 
-	/**
-	 * @psalm-suppress MethodSignatureMustProvideReturnType
-	 */
 	public function fopen($path, $mode) {
 		if ($this->checkPath($path)) {
 			return parent::fopen($path, $mode);
@@ -203,10 +189,7 @@ public function fopen($path, $mode) {
 		}
 	}
 
-	/**
-	 * @psalm-suppress MethodSignatureMustProvideReturnType
-	 */
-	public function getCache($path = '', $storage = null) {
+	public function getCache($path = '', $storage = null): ICache {
 		if (!$storage) {
 			$storage = $this;
 		}