Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guests should auto-accept incoming shares #222

Closed
wiswedel opened this issue Dec 13, 2019 · 7 comments · Fixed by #272
Closed

Guests should auto-accept incoming shares #222

wiswedel opened this issue Dec 13, 2019 · 7 comments · Fixed by #272
Assignees
@rullzer
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request

Comments

@wiswedel
Copy link
Contributor

Since in 18 all shares have to be accepted (nextcloud/server#16828), guests find an empty Nextcloud on first login.
Guest users should always auto-accept incoming shares, since receiving shares is the main reason for being a guest user after all.

Suggestion

have personal auto-accept settiing set to true by default for guest users

Side effort

Guest users who never have logged in as guests, but come as converted users (#208) in the first place, don't even see the incoming-share-notification and therefore can never accept the share.
@wiswedel wiswedel added enhancement New feature or request 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Dec 13, 2019
@wiswedel
Copy link
Contributor Author

CC @ChristophWurst

@wiswedel wiswedel added the bug Something isn't working label Dec 13, 2019
@wiswedel
Copy link
Contributor Author

ref nextcloud/server#18385

@ChristophWurst
Copy link
Member

Could be done in guests very similar to the UserShareAcceptanceListener in https://github.com/nextcloud/server/pull/18385/files#diff-dd0ce0f36cf8170b416d7d09954cc6dfR33

@wiswedel
Copy link
Contributor Author

wiswedel commented Jan 2, 2020

This should be addressed before the 18 release. Otherwise it breaks the Guests app's UX.

@rullzer
Copy link
Member

rullzer commented Jan 2, 2020

Yeah well we have other stuff to fix first. If guests also have to press accept for now so be it.
It is on the list but not very high. Esp since we can fix it a week later as well in a separate release.

@wiswedel
Copy link
Contributor Author

wiswedel commented Jan 3, 2020

fix it a week later as well in a separate release

That'll be fine. Thanks.

@wiswedel wiswedel mentioned this issue Jan 6, 2020
Merged
@rullzer rullzer self-assigned this Jan 30, 2020
@rullzer
Copy link
Member

rullzer commented Jan 30, 2020

Let me take care of this oonish

rullzer added a commit that referenced this issue Feb 3, 2020
@rullzer
Guest users always auto accept shares
a48f93d 
Fixes #222

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer removed the bug Something isn't working label Feb 3, 2020
@rullzer rullzer mentioned this issue Feb 3, 2020
Merged
rullzer added a commit that referenced this issue Feb 3, 2020
@rullzer
Guest users always auto accept shares
9549311 
Fixes #222

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rullzer rullzer

Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Guest users always auto accept shares nextcloud/guests
3 participants
@rullzer @ChristophWurst @wiswedel