Replace "transfer" notion with "convert" notion

[Jerome-Herbinet]

Replace "transfer" notion with "convert" notion

Test from reviewers needed.

Fixes: #1221 (except menu entries order which is IMO another development … that I can't do myself)

[Jerome-Herbinet]

@Pytal (you or another possible reviewer) I need you to test ; thanks by advance.

[jancborchardt]

Seems good to me – I only don’t know how the more complex constructions like this one would come out:

$l->t('Conversion of guest {guest} account to {user} account completed'),

The previous simpler way without the 2 "account" wordings seems nicer? But @Jerome-Herbinet if you have examples of before/after how it will actually come out with example wording that would be nice.

[Jerome-Herbinet]

Seems good to me – I only don’t know how the more complex constructions like this one would come out:

$l->t('Conversion of guest {guest} account to {user} account completed'),

The previous simpler way without the 2 "account" wordings seems nicer? But @Jerome-Herbinet if you have examples of before/after how it will actually come out with example wording that would be nice.

@jancborchardt you are right ; the sentence is a bit complex, but I think that giving enough details is necessary in this process. I would even prefer, even it's longer (guest vs. regular) :

Conversion of {guest} guest account to {user} regular account completed

... and to apply to the other wordings.

[jancborchardt]

@Pytal since you are more pro at English, what do you suggest? :D

I would prefer to go with a simple and concise sentence as that often is more understandable.

[Pytal]

Both ways have valid points I think — considering the messages in isolation and without assuming contextual knowledge I would say the more explicit messaging makes sense

[jancborchardt]

@Jerome-Herbinet could you still show how these would come out in practice?

$l->t('Failed to convert guest {guest} account to {user} account')
$l->t('Conversion of guest {guest} account to {user} account completed')

[Jerome-Herbinet]

'Conversion of guest {guest} account to {user} account completed'

@Jerome-Herbinet could you still show how these would come out in practice?

$l->t('Failed to convert guest {guest} account to {user} account')
$l->t('Conversion of guest {guest} account to {user} account completed')

I won't be able to test it @jancborchardt

[jancborchardt]

@Pytal do you know what will come out of those sentences? :D It would be important to know so we can decide on the proper wording.

[Pytal]

@jancborchardt looks like this

[Pytal]

With the longer version "Conversion of guest account, {guest}, to regular account, {user}, completed" would be better but will let you decide @jancborchardt :)

[jancborchardt]

Thanks @Pytal! :) I think it is a bit cumbersome and would be way better with both occurences of "account" deleted, so it is like this:

Conversion of guest test1@example.com to (test1) completed

Especially as the proper account has the userbubble then, it’s way easier to read.

[Jerome-Herbinet]

Thanks @Pytal! :) I think it is a bit cumbersome and would be way better with both occurences of "account" deleted, so it is like this:

Conversion of guest test1@example.com to (test1) completed

Especially as the proper account has the userbubble then, it’s way easier to read.

@jancborchardt check my 2 last commits.

[jancborchardt]

Good stuff, thanks @Jerome-Herbinet and sorry for the back and forth :)

[Pytal]

/backport to stable30

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)