fix: Implement new function required by IManager #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems you need to drop 30-32 from supported versions 🙈 |
leftybournes
force-pushed
the
leftybournes/fix/filtered_settings_manager
branch
from
b641a8d to
8647320
Compare
Contributor
Author
|
I went with the approach of throwing if called on server versions 32 or lower |
come-nc
approved these changes
Sep 30, 2025
Signed-off-by: Kent Delante <kent.delante@proton.me>
leftybournes
force-pushed
the
leftybournes/fix/filtered_settings_manager
branch
from
8647320 to
0b84555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.