Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README updates: Add replicaCount; fix image.flavor, nextcloud.podSecurityContext descriptions #337

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Conversation

jessebot
Copy link
Collaborator

Pull Request

Description of the change

This is just updates to the README to include a little bit more info on:

  • image.flavor (updates table desc, and adds small section below)
  • nextcloud.podSecurityContext (updates table desc)
  • replicaCount (adds param to table)

Benefits

Easier cross reference between the values.yaml and README.md to save time on getting started :)

Possible drawbacks

I don't really see any drawbacks to updating the readme.

Applicable issues

Additional information

This is a change only to the README and does not add additional features, so the Chart.yaml doesn't need a version update.

Checklist

these are for different webserver backends. You must use fpm if you're deploying nginx as your webserver instead of apache.

Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
@jessebot jessebot changed the title README updates: Add replicaCount; fix image.flavor, nextcloud.podSecurityContext descriptions README updates: Add replicaCount; fix image.flavor, nextcloud.podSecurityContext descriptions Jan 24, 2023
charts/nextcloud/README.md Outdated Show resolved Hide resolved
@provokateurin
Copy link
Member

Please fix DCO and conflicts.

…ADME

Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: JesseBot <jessebot@linux.com>
@jessebot
Copy link
Collaborator Author

If anyone is curious on future markdown table formatting, in vim I use this plugin: vim-table-mode. Then you can just use the command :TableModeEnable and it will auto-format the markdown table as you change modes in vim.

@provokateurin provokateurin merged commit a491977 into nextcloud:master Jan 25, 2023
@provokateurin
Copy link
Member

Awesome! ❤️

@jessebot jessebot deleted the update_readme_options branch January 25, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replicaCount not mentioned in Readme README and values.yaml comments don't list options for image.flavor
2 participants