-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: client push #551
base: main
Are you sure you want to change the base?
Feature: client push #551
Conversation
Can we install apps with commands? If so, it can be added as default. |
image: {{ include "nextcloud.image" . }} | ||
imagePullPolicy: {{ .Values.image.pullPolicy }} | ||
command: | ||
- custom_apps/notify_push/bin/x86_64/notify_push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard-coded x86_64
c4ce530
to
d57a66d
Compare
Signed-off-by: Andre Köpke <github@akop.online>
d57a66d
to
9d79183
Compare
there is |
I really like the idea to run notify_push. But please in a different way:
The reason:
Another reason (i need to verify / hope that it exists), we could use a other image for the client push (without any distro inside thanks Rust) and track a more beautiful/helm-like way the version. (That image exists but is not official yet: nextcloud/notify_push#106 (comment)) PS: it will also solve the CPU architecture problem (the notify_push image should just build in all targets under the same container label). i start to write, what i mean under: #581 |
I like your changes. I'm running my variant since I opened the PR, but I will switch to your variant in the next days. |
Till there is a solution merged i would keep it open in your place. |
Pull Request
Description of the change
Add a container for client_push app. It allows websocket-connections for updates instead of polling. See notify_push
Benefits
Possible drawbacks
sudo -u www-data ./occ notify_push:setup https://NEXTCLOUD_HOST/push
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver.