Update some npm pkgs and make adjustments

[julien-nc]

@nextcloud/axios @nextcloud/eslint-config @nextcloud/router @nextcloud/stylelint-config @nextcloud/vue @nextcloud/webpack-vue-config vue vue-material-design-icons @nextcloud/dialogs and vue-template-compiler were updated.
Some small adjustments were needed.

@vue/cli-plugin-unit-jest was not updated, just in case.
Anyway the jest snapshots probably need to be regenerated.

[SwikritiT]

I've updated the snapshots some of the tests are still failing, I'll take a look on why they are failing

[SwikritiT]

with nextcloud-23 on admin/personal settings section, the dialog is not shown.

nc-dialogs-2023-04-04_13.49.25.mp4

[julien-nc]

Hey @SwikritiT, I managed to upgrade everything except

• @nextcloud/dialogs
• @vue/cli-plugin-unit-jest
• @vue/test-utils
• @vue/vue2-jest

To make sure we could properly update some pkgs, i had to set a fixed version for the @vue/* ones so we could have a coherent dependency tree by running npm update.

Sorry i started from scratch and force-pushed on this branch. Could you update the snapshots again?

[SwikritiT]

Hey @SwikritiT, I managed to upgrade everything except

• @nextcloud/dialogs
• @vue/cli-plugin-unit-jest
• @vue/test-utils
• @vue/vue2-jest

To make sure we could properly update some pkgs, i had to set a fixed version for the @vue/* ones so we could have a coherent dependency tree by running npm update.

Sorry i started from scratch and force-pushed on this branch. Could you update the snapshots again?

Okay, I'll update the snapshots. Thank you.

[github-actions]

JS Code Coverage

Coverage after merging enh/noid/update-some-npm-pkgs into master will be

93.74%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
adminSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
bootstrap.js	0%	0%	0%	0%	1, 1–7
dashboard.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
fileActions.js	0%	0%	0%	0%	1, 1, 10–17, 2–9
personalSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
projectTab.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–66, 7–9
utils.js	57.45%	33.33%	50%	59.52%	10–14, 17–26, 6–9
src/components
AdminSettings.vue	99.23%	96.15%	83.33%	99.86%	1, 1, 1
OAuthConnectButton.vue	99.07%	87.50%	100%	100%	1
PersonalSettings.vue	98.90%	93.33%	85.71%	100%	1
src/components/admin
FieldValue.vue	96.84%	83.33%	100%	98.77%	1, 23, 23
FormHeading.vue	97.03%	66.67%	100%	98.92%	1, 18, 18
TextInput.vue	99.25%	95%	88.89%	100%	1
src/components/icons
ClippyIcon.vue	93.18%	50%	50%	97.50%	1, 1
src/components/settings
CheckBox.vue	92.45%	80%	66.67%	97.62%	1, 1
SettingsTitle.vue	94.74%	50%	100%	97.14%	1, 1
src/components/tab
EmptyContent.vue	98.06%	84.62%	100%	99.29%	1, 29, 29
SearchInput.vue	99.57%	88.89%	100%	100%	1
WorkPackage.vue	98.36%	40%	100%	99.33%	1, 1, 1, 43, 43
src/utils
workpackageHelper.js	97.32%	94.74%	100%	97.75%	17–19
src/views
Dashboard.vue	98.04%	62.50%	60%	99.66%	1, 1, 1, 1
ProjectsTab.vue	99.74%	93.75%	100%	100%	23

[github-actions]

PHP Code Coverage

Coverage after merging enh/noid/update-some-npm-pkgs into master will be

58.24%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
server/apps/integration_openproject/lib/AppInfo
Application.php	12.50%	100%	25%	10.71%	103–108, 119, 123, 65–66, 69, 73, 76, 82, 84–86, 88–90, 94–97, 99
server/apps/integration_openproject/lib/BackgroundJob
RemoveExpiredDirectUploadTokens.php	0%	100%	0%	0%	42, 44–46, 55–56
server/apps/integration_openproject/lib/Controller
ConfigController.php	63.25%	100%	50%	64.09%	131, 148–149, 151, 153–155, 157–158, 163–164, 166, 198–205, 332–333, 462–465, 467–468, 471, 479, 490, 504–506, 521–525, 527–528, 530–533, 535–537, 555–562, 564, 566, 569–571, 573–575, 589, 597–600, 602–605, 615–620
DirectDownloadController.php	0%	100%	0%	0%	36–38, 53–55, 57, 60–61
DirectUploadController.php	71.43%	100%	100%	70.43%	131–132, 177, 190, 194–197, 199, 209, 216, 232–234, 236–237, 240–242, 248, 250, 255–256, 263–264, 267–268, 271–272, 288–289, 309, 314, 320
FilesController.php	78.86%	100%	100%	77.59%	168, 220–221, 272, 278–282, 286–288, 290, 292, 303–305, 308–309, 311–312, 316–319, 322
OpenProjectAPIController.php	85.07%	100%	78.57%	85.56%	136, 171, 188–189, 193, 197, 199–204, 206, 215–216, 219, 221, 223–226, 228–229, 234, 253, 278, 95
server/apps/integration_openproject/lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	101–102, 104–108, 116, 123–124, 126, 128–129, 131–132, 134, 137–138, 140–141, 143, 69–73, 80, 87, 94
server/apps/integration_openproject/lib/Exception
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectFileNotUploadedException.php	100%	100%	100%	100%
OpenprojectGroupfolderSetupConflictException.php	0%	100%	0%	0%	20
OpenprojectResponseException.php	100%	100%	100%	100%
OpenprojectUnauthorizedUserException.php	0%	100%	0%	0%	16
server/apps/integration_openproject/lib/Listener
BeforeGroupDeletedListener.php	0%	100%	0%	0%	45, 53–54, 57–60
BeforeNodeInsideOpenProjectGroupfilderChangedListener.php	0%	100%	0%	0%	43–46, 50–55, 57–60, 63–65, 67, 69, 73
BeforeUserDeletedListener.php	0%	100%	0%	0%	45, 52–53, 55–58
LoadSidebarScript.php	0%	100%	0%	0%	101, 103–105, 107, 109, 111–112, 114–115, 117, 119, 72–78, 80–81, 83–84, 86–87, 93–94, 96–97, 99
UserChangedListener.php	0%	100%	0%	0%	49, 56–57, 60–64
server/apps/integration_openproject/lib/Migration
Version2001Date20221213083550.php	0%	100%	0%	0%	47, 57, 60, 63, 67, 70, 73, 77–79, 81
Version2310Date20230116153411.php	0%	100%	0%	0%	46, 49–52, 54–56, 60, 64, 68, 72, 76, 81–82, 84
server/apps/integration_openproject/lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	102, 109–110, 113–118, 120–121, 123–125, 128–129, 131–132, 136–141, 147–148, 150, 159–163, 171–179, 195–202, 211–216, 71–75, 82, 89, 97, 99
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
server/apps/integration_openproject/lib/Service
DatabaseService.php	43.90%	100%	60%	41.67%	125–128, 131, 80–87, 89–93, 95–97
DirectDownloadService.php	88%	100%	100%	86.96%	65–66, 68
DirectUploadService.php	54.55%	100%	66.67%	52.63%	112, 118, 79–82, 84, 89, 91
OauthService.php	0%	100%	0%	0%	37–38, 47–53, 55, 64–67, 78–85, 95–99
OpenProjectAPIService.php	75.06%	100%	78.79%	74.72%	167–171, 342–343, 345, 359–360, 369, 373, 394, 482–483, 490, 493–496, 498, 504, 508–510, 530, 539–542, 546–548, 553–555, 558–560, 562, 565–566, 569, 735, 806, 836–837, 839, 841–842, 865, 869, 873–874, 877–880, 882–883, 885–886, 888–889, 897–904, 910, 936, 938, 941, 944, 950, 955, 959, 965–967, 970, 972, 977, 979, 982, 984
server/apps/integration_openproject/lib/Settings
Admin.php	0%	100%	0%	0%	32–34, 41–43, 46–50, 53, 58–59, 62, 64–65, 67, 71, 75
AdminSection.php	0%	100%	0%	0%	19–20, 29, 39, 48, 55
Personal.php	87.88%	100%	50%	93.10%	94, 98
PersonalSection.php	0%	100%	0%	0%

[SwikritiT]

Did some manual testing with different versions of NC, no problem in UI