Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String fixes #381

Merged
merged 2 commits into from
Apr 11, 2023
Merged

String fixes #381

merged 2 commits into from
Apr 11, 2023

Conversation

silopolis
Copy link
Contributor

Small plurals in AdminSettings.vue component

@SwikritiT SwikritiT requested a review from phil-davis April 3, 2023 06:40
phil-davis
phil-davis approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/components/AdminSettings.vue Show resolved Hide resolved
@SwikritiT
Copy link
Contributor

SwikritiT commented Apr 5, 2023 •
edited
Loading

Hi, @silopolis thank you for this PR. Some of the unit tests are failing because of this.
Can you please update with the same changes here as well?

integration_openproject/tests/jest/components/AdminSettings.spec.js

Line 953 in 9f82042

expect(dialogs.showSuccess).toBeCalledWith('Successfully revoked user(s) OpenProject OAuth access token(s)')

integration_openproject/tests/jest/components/AdminSettings.spec.js

Line 958 in 9f82042

['other_error', 'Failed to revoke some user(s) OpenProject OAuth access token(s)'],

@silopolis
Copy link
Contributor Author

Of course, will do later today 👍

@silopolis
chore(git): Ignore '*.code-workspace' files
9bce179 
Signed-off-by: Jérémie Tarot (@silopolis) <silopolis@gmail.com>
@silopolis
fix(strings): Small plurals fixes in AdminSettings
6c50df8 
Signed-off-by: Jérémie Tarot (@silopolis) <silopolis@gmail.com>
@silopolis
Copy link
Contributor Author

A bit late, but done :)

@SwikritiT SwikritiT requested a review from individual-it April 11, 2023 07:23
@SwikritiT
Copy link
Contributor

SwikritiT commented Apr 11, 2023 •
edited
Loading

@individual-it maybe we can merge this? The tests are passing
https://github.com/nextcloud/integration_openproject/actions/runs/4626387905/jobs/8184501756
CI is red because the coverage cannot be posted from a fork.

@individual-it individual-it merged commit 161daf2 into nextcloud:master Apr 11, 2023
@SwikritiT SwikritiT mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it individual-it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silopolis @SwikritiT @phil-davis @individual-it