[OP#47630] Check if free space is a positive value

[SwikritiT]

Currently we're checking quota like this

$freeSpace = $folderNode->getFreeSpace();

// this is also true if we try to overwrite
// to overwrite a file we need enough free quota for the new data
// otherwise `putContent()` fails
if ($directUploadFile['size'] > $freeSpace) {
	throw new NotEnoughSpaceException('insufficient quota');
}

But since there's a possibility that the function getFreeSpace might return a negative

https://github.com/nextcloud/server/blob/b1abc57c07a61b5a0557395d86c3e31486a96c23/lib/public/Files/FileInfo.php#L52

https://github.com/nextcloud/server/blob/b1abc57c07a61b5a0557395d86c3e31486a96c23/lib/public/Files/FileInfo.php#L57

https://github.com/nextcloud/server/blob/b1abc57c07a61b5a0557395d86c3e31486a96c23/lib/public/Files/FileInfo.php#L62

So treat a negative return as an unlimited space

Related work package: https://community.openproject.org/projects/nextcloud-integration/work_packages/47630/activity?query_id=3504

[individual-it]

looks good, can we add unit tests for that case?

[SwikritiT]

looks good, can we add unit tests for that case?

yes I can add it

[github-actions]

JS Code Coverage

Coverage after merging handle-negative-return-value-of-free-space into release/2.3 will be

93.82%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
adminSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
bootstrap.js	0%	0%	0%	0%	1, 1–7
dashboard.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–27, 3–9
fileActions.js	0%	0%	0%	0%	1, 1, 10–17, 2–9
personalSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
projectTab.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–66, 7–9
utils.js	57.45%	33.33%	50%	59.52%	10–14, 17–26, 6–9
src/components
AdminSettings.vue	99.24%	95.92%	82.35%	99.86%	1, 1, 1
OAuthConnectButton.vue	99.09%	80%	100%	100%	1
PersonalSettings.vue	98.88%	91.67%	83.33%	100%	1
src/components/admin
FieldValue.vue	95.56%	62.50%	100%	98.77%	1, 1, 1, 1
FormHeading.vue	98.98%	75%	100%	100%	1
TextInput.vue	98.46%	80%	87.50%	100%	1, 1, 1
src/components/icons
ClippyIcon.vue	93.18%	50%	50%	97.50%	1, 1
src/components/settings
CheckBox.vue	92.45%	80%	66.67%	97.62%	1, 1
SettingsTitle.vue	94.74%	50%	100%	97.14%	1, 1
src/components/tab
EmptyContent.vue	99.34%	90.91%	100%	100%	1
SearchInput.vue	99.56%	83.33%	100%	100%	1
WorkPackage.vue	99.01%	33.33%	100%	99.66%	1, 1, 1
src/utils
workpackageHelper.js	97.46%	96%	100%	97.75%	17–19
src/views
Dashboard.vue	98.36%	50%	50%	99.66%	1, 1, 1
ProjectsTab.vue	99.74%	92.31%	100%	100%	23

[github-actions]

PHP Code Coverage

Coverage after merging handle-negative-return-value-of-free-space into release/2.3 will be

60.13%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
server/apps/integration_openproject/lib/AppInfo
Application.php	14.81%	100%	25%	13.04%	101, 105, 56–57, 60, 67, 69–71, 76–79, 81, 85–90
server/apps/integration_openproject/lib/BackgroundJob
RemoveExpiredDirectUploadTokens.php	0%	100%	0%	0%	42, 44–46, 55–56
server/apps/integration_openproject/lib/Controller
ConfigController.php	67.62%	100%	50%	68.88%	105, 122–123, 125, 127–129, 131–132, 137–138, 140, 416–419, 421–422, 425, 433, 444, 458–460, 475–479, 481–484, 502–509, 511, 513, 516–518, 532, 540–543, 545–548, 558–563
DirectDownloadController.php	0%	100%	0%	0%	36–38, 53–55, 57, 60–61
DirectUploadController.php	71.43%	100%	100%	70.43%	131–132, 177, 188, 192–195, 197, 207, 214, 230–232, 234–235, 238–240, 246, 248, 253–254, 261–262, 265–266, 269–270, 286–287, 307, 312, 318
FilesController.php	73.74%	100%	100%	72.04%	168, 221–222, 267, 273–277, 281–283, 285, 287, 298–300, 303–304, 306–307, 311–314, 317
OpenProjectAPIController.php	85.07%	100%	78.57%	85.56%	136, 171, 188–189, 193, 197, 199–204, 206, 215–216, 219, 221, 223–226, 228–229, 234, 253, 278, 95
server/apps/integration_openproject/lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	101–102, 104–108, 116, 123–124, 126, 128–129, 131–132, 134, 137–138, 140–141, 143, 69–73, 80, 87, 94
server/apps/integration_openproject/lib/Exception
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectFileNotUploadedException.php	100%	100%	100%	100%
OpenprojectResponseException.php	100%	100%	100%	100%
OpenprojectUnauthorizedUserException.php	0%	100%	0%	0%	16
server/apps/integration_openproject/lib/Listener
LoadSidebarScript.php	0%	100%	0%	0%	101, 103–105, 107, 109, 111–112, 114–115, 117, 119, 72–78, 80–81, 83–84, 86–87, 93–94, 96–97, 99
server/apps/integration_openproject/lib/Migration
Version2001Date20221213083550.php	0%	100%	0%	0%	47, 57, 60, 63, 67, 70, 73, 77–79, 81
Version2310Date20230116153411.php	0%	100%	0%	0%	46, 49–52, 54–56, 60, 64, 68, 72, 76, 81–82, 84
server/apps/integration_openproject/lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	102, 109–110, 113–118, 120–121, 123–125, 128–129, 131–132, 136–141, 147–148, 150, 159–163, 171–179, 195–202, 211–216, 71–75, 82, 89, 97, 99
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
server/apps/integration_openproject/lib/Service
DatabaseService.php	43.90%	100%	60%	41.67%	125–128, 131, 80–87, 89–93, 95–97
DirectDownloadService.php	88%	100%	100%	86.96%	65–66, 68
DirectUploadService.php	54.55%	100%	66.67%	52.63%	112, 118, 79–82, 84, 89, 91
OauthService.php	0%	100%	0%	0%	37–38, 47–53, 55, 64–67, 78–85, 95–99
OpenProjectAPIService.php	77.99%	100%	83.33%	77.54%	113–117, 288–289, 291, 305–306, 315, 319, 340, 428–429, 436, 439–442, 444, 450, 454–456, 476, 484–487, 491–493, 498–500, 503–505, 507, 510–511, 514, 680, 751, 781–782, 784, 786–787, 810, 814, 818–819, 822–825, 827–828, 830–831, 833–834
server/apps/integration_openproject/lib/Settings
Admin.php	0%	100%	0%	0%	32–34, 41–43, 46–50, 53, 58–59, 62, 64–65, 67, 71, 75
AdminSection.php	0%	100%	0%	0%	19–20, 29, 39, 48, 55
Personal.php	87.88%	100%	50%	93.10%	94, 98
PersonalSection.php	0%	100%	0%	0%	19–20, 29, 39, 48, 55