-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[op#48127]Add new params as required by the constructor of FolderManager class #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
SwikritiT
changed the title
[op#48127]Add required params as required by the constructor of FolderManager class
[op#48127]Add new params as required by the constructor of FolderManager class
May 8, 2023
JS Code CoverageCoverage after merging fix/add-new-params-in-group-folders into master will be
Coverage Report
|
individual-it
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API tests were failing in CI and locally with
There was a new beta release of the group folders app https://github.com/nextcloud/groupfolders/releases/tag/v15.0.0-beta1
Seems like there were certain updates in FolderManager class in the latest version that added new values in the constructor. As these changes were made in the latest version of the app, they should only be supported by the latest master. This PR adds the new required parameters.
Related work package: https://community.openproject.org/projects/nextcloud-integration/work_packages/48127