rely on foldername not fileID for delete protection of project folders

[individual-it]

Relying on the fileID might be problematic because the admin might have deleted the OpenProject groupfolder and recreated it, in that case the fileID would have changed, but we would not know about it
Signed-off-by: Artur Neumann artur@jankaritech.com

[SwikritiT]

LGTM

[SagarGi]

LGTM 👍

[github-actions]

JS Code Coverage

Coverage after merging folderNameForDeleteProtection into master will be

93.75%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
adminSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
bootstrap.js	0%	0%	0%	0%	1, 1–7
dashboard.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
fileActions.js	0%	0%	0%	0%	1, 1, 10–17, 2–9
personalSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
projectTab.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–66, 7–9
utils.js	57.45%	33.33%	50%	59.52%	10–14, 17–26, 6–9
src/components
AdminSettings.vue	99.23%	96.15%	83.33%	99.86%	1, 1, 1
OAuthConnectButton.vue	99.07%	87.50%	100%	100%	1
PersonalSettings.vue	98.90%	93.33%	85.71%	100%	1
src/components/admin
FieldValue.vue	96.84%	83.33%	100%	98.77%	1, 23, 23
FormHeading.vue	97.03%	66.67%	100%	98.92%	1, 18, 18
TextInput.vue	99.25%	95%	88.89%	100%	1
src/components/icons
ClippyIcon.vue	93.18%	50%	50%	97.50%	1, 1
src/components/settings
CheckBox.vue	92.45%	80%	66.67%	97.62%	1, 1
SettingsTitle.vue	94.74%	50%	100%	97.14%	1, 1
src/components/tab
EmptyContent.vue	98.06%	84.62%	100%	99.29%	1, 29, 29
SearchInput.vue	99.57%	88.89%	100%	100%	1
WorkPackage.vue	98.36%	40%	100%	99.33%	1, 1, 1, 43, 43
src/utils
workpackageHelper.js	97.32%	94.74%	100%	97.75%	17–19
src/views
Dashboard.vue	98.04%	62.50%	60%	99.66%	1, 1, 1, 1
ProjectsTab.vue	99.74%	93.75%	100%	100%	23

[github-actions]

PHP Code Coverage

Coverage after merging folderNameForDeleteProtection into master will be

58.06%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
server/apps/integration_openproject/lib/AppInfo
Application.php	12.50%	100%	25%	10.71%	103–108, 119, 123, 65–66, 69, 73, 76, 82, 84–86, 88–90, 94–97, 99
server/apps/integration_openproject/lib/BackgroundJob
RemoveExpiredDirectUploadTokens.php	0%	100%	0%	0%	42, 44–46, 55–56
server/apps/integration_openproject/lib/Controller
ConfigController.php	63.64%	100%	50%	64.52%	131, 148–149, 151, 153–155, 157–158, 163–164, 166, 197–204, 330–331, 460–463, 465–466, 469, 477, 488, 502–504, 519–523, 525–528, 530–532, 550–557, 559, 561, 564–566, 568–570, 584, 592–595, 597–600, 610–615
DirectDownloadController.php	0%	100%	0%	0%	36–38, 53–55, 57, 60–61
DirectUploadController.php	71.43%	100%	100%	70.43%	131–132, 177, 190, 194–197, 199, 209, 216, 232–234, 236–237, 240–242, 248, 250, 255–256, 263–264, 267–268, 271–272, 288–289, 309, 314, 320
FilesController.php	78.86%	100%	100%	77.59%	168, 220–221, 272, 278–282, 286–288, 290, 292, 303–305, 308–309, 311–312, 316–319, 322
OpenProjectAPIController.php	85.07%	100%	78.57%	85.56%	136, 171, 188–189, 193, 197, 199–204, 206, 215–216, 219, 221, 223–226, 228–229, 234, 253, 278, 95
server/apps/integration_openproject/lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	101–102, 104–108, 116, 123–124, 126, 128–129, 131–132, 134, 137–138, 140–141, 143, 69–73, 80, 87, 94
server/apps/integration_openproject/lib/Exception
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectFileNotUploadedException.php	100%	100%	100%	100%
OpenprojectGroupfolderSetupConflictException.php	0%	100%	0%	0%	20
OpenprojectResponseException.php	100%	100%	100%	100%
OpenprojectUnauthorizedUserException.php	0%	100%	0%	0%	16
server/apps/integration_openproject/lib/Listener
BeforeGroupDeletedListener.php	0%	100%	0%	0%	45, 53–54, 57–60
BeforeNodeInsideOpenProjectGroupfilderChangedListener.php	0%	100%	0%	0%	37–39, 43–48, 50–55, 57, 59, 63
BeforeUserDeletedListener.php	0%	100%	0%	0%	45, 52–53, 55–58
LoadSidebarScript.php	0%	100%	0%	0%	101, 103–105, 107, 109, 111–112, 114–115, 117, 119, 72–78, 80–81, 83–84, 86–87, 93–94, 96–97, 99
UserChangedListener.php	0%	100%	0%	0%	49, 56–57, 60–64
server/apps/integration_openproject/lib/Migration
Version2001Date20221213083550.php	0%	100%	0%	0%	47, 57, 60, 63, 67, 70, 73, 77–79, 81
Version2310Date20230116153411.php	0%	100%	0%	0%	46, 49–52, 54–56, 60, 64, 68, 72, 76, 81–82, 84
server/apps/integration_openproject/lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	102, 109–110, 113–118, 120–121, 123–125, 128–129, 131–132, 136–141, 147–148, 150, 159–163, 171–179, 195–202, 211–216, 71–75, 82, 89, 97, 99
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
server/apps/integration_openproject/lib/Service
DatabaseService.php	43.90%	100%	60%	41.67%	125–128, 131, 80–87, 89–93, 95–97
DirectDownloadService.php	88%	100%	100%	86.96%	65–66, 68
DirectUploadService.php	54.55%	100%	66.67%	52.63%	112, 118, 79–82, 84, 89, 91
OauthService.php	0%	100%	0%	0%	37–38, 47–53, 55, 64–67, 78–85, 95–99
OpenProjectAPIService.php	73.94%	100%	75%	73.84%	167–171, 343–344, 346, 360–361, 370, 374, 395, 483–484, 491, 494–497, 499, 505, 509–511, 531, 540–543, 547–549, 554–556, 559–561, 563, 566–567, 570, 736, 807, 837–838, 840, 842–843, 866, 870, 874–875, 878–881, 883–884, 886–887, 889–890, 898–905, 911, 935, 937, 940, 943, 949, 954, 958, 968, 970, 973, 975, 980, 982–985, 988
server/apps/integration_openproject/lib/Settings
Admin.php	0%	100%	0%	0%	32–34, 41–43, 46–50, 53, 58–59, 62, 64–65, 67, 71, 75
AdminSection.php	0%	100%	0%	0%	19–20, 29, 39, 48, 55
Personal.php	87.88%	100%	50%	93.10%	94, 98
PersonalSection.php	0%	100%	0%	0%	19–20, 29,