Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OP#48443]Installed additional module, authenticated docker hub for more image pull #420

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

SagarGi
Copy link
Collaborator

@SagarGi SagarGi commented Jun 1, 2023

Description

1.The php gd extension is required for the CI and also extension sqlite3 is need in order to install nextcloud in sqlite to run unit tests. This PR adds those modules. Other wise CI gives error like below:

PHP module GD not installed.
Please ask your server administrator to install the module.

An unhandled exception has been thrown:
Exception: Environment not properly prepared. in /home/runner/actions-
  1. Also this PR authenticates to docker in the CI to increase the limit of the image pull for different services in the github actions workflow. Other wise CI gives error like below:
 Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
  Error: Docker pull failed with exit code 1
  1. Also added sqlite3 extension to be able to install the nextcloud with it

  2. Also adds new step to set up .NET core required to execute the Convert PHP cobertura coverage to lcov step in CI

  3. Bump ubuntu to 20.04 since it exists with error disk quota exceeded.

Related work package: https://community.openproject.org/projects/nextcloud-integration/work_packages/48443

@SagarGi SagarGi force-pushed the use_old_php_version_for_unittest branch 28 times, most recently from 89dd40a to 529775f Compare June 2, 2023 06:03
@SagarGi SagarGi changed the title Use old php version for unit test Installed additional module, authenticated docker hub for more image pull Jun 2, 2023
@SagarGi SagarGi force-pushed the use_old_php_version_for_unittest branch from 529775f to b48c7be Compare June 2, 2023 06:24
@SagarGi SagarGi force-pushed the use_old_php_version_for_unittest branch 15 times, most recently from 7eff342 to 3c66e2f Compare June 6, 2023 08:33
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
@SagarGi SagarGi force-pushed the use_old_php_version_for_unittest branch from 3c66e2f to 97396fe Compare June 6, 2023 08:42
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

JS Code Coverage

Coverage after merging use_old_php_version_for_unittest into master will be
93.75%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   bootstrap.js0%0%0%0%1, 1–7
   dashboard.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   fileActions.js0%0%0%0%1, 1, 10–17, 2–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–66, 7–9
   utils.js57.45%33.33%50%59.52%10–14, 17–26, 6–9
src/components
   AdminSettings.vue99.23%96.15%83.33%99.86%1, 1, 1
   OAuthConnectButton.vue99.07%87.50%100%100%1
   PersonalSettings.vue98.90%93.33%85.71%100%1
src/components/admin
   FieldValue.vue96.84%83.33%100%98.77%1, 23, 23
   FormHeading.vue97.03%66.67%100%98.92%1, 18, 18
   TextInput.vue99.25%95%88.89%100%1
src/components/icons
   ClippyIcon.vue93.18%50%50%97.50%1, 1
src/components/settings
   CheckBox.vue92.45%80%66.67%97.62%1, 1
   SettingsTitle.vue94.74%50%100%97.14%1, 1
src/components/tab
   EmptyContent.vue98.06%84.62%100%99.29%1, 29, 29
   SearchInput.vue99.57%88.89%100%100%1
   WorkPackage.vue98.36%40%100%99.33%1, 1, 1, 43, 43
src/utils
   workpackageHelper.js97.32%94.74%100%97.75%17–19
src/views
   Dashboard.vue98.04%62.50%60%99.66%1, 1, 1, 1
   ProjectsTab.vue99.74%93.75%100%100%23

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

PHP Code Coverage

Coverage after merging use_old_php_version_for_unittest into master will be
58.06%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
server/apps/integration_openproject/lib/AppInfo
   Application.php12.50%100%25%10.71%103–108, 119, 123, 65–66, 69, 73, 76, 82, 84–86, 88–90, 94–97, 99
server/apps/integration_openproject/lib/BackgroundJob
   RemoveExpiredDirectUploadTokens.php0%100%0%0%42, 44–46, 55–56
server/apps/integration_openproject/lib/Controller
   ConfigController.php63.64%100%50%64.52%131, 148–149, 151, 153–155, 157–158, 163–164, 166, 197–204, 330–331, 460–463, 465–466, 469, 477, 488, 502–504, 519–523, 525–528, 530–532, 550–557, 559, 561, 564–566, 568–570, 584, 592–595, 597–600, 610–615
   DirectDownloadController.php0%100%0%0%36–38, 53–55, 57, 60–61
   DirectUploadController.php71.43%100%100%70.43%131–132, 177, 190, 194–197, 199, 209, 216, 232–234, 236–237, 240–242, 248, 250, 255–256, 263–264, 267–268, 271–272, 288–289, 309, 314, 320
   FilesController.php78.86%100%100%77.59%168, 220–221, 272, 278–282, 286–288, 290, 292, 303–305, 308–309, 311–312, 316–319, 322
   OpenProjectAPIController.php85.07%100%78.57%85.56%136, 171, 188–189, 193, 197, 199–204, 206, 215–216, 219, 221, 223–226, 228–229, 234, 253, 278, 95
server/apps/integration_openproject/lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101–102, 104–108, 116, 123–124, 126, 128–129, 131–132, 134, 137–138, 140–141, 143, 69–73, 80, 87, 94
server/apps/integration_openproject/lib/Exception
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectFileNotUploadedException.php100%100%100%100%
   OpenprojectGroupfolderSetupConflictException.php0%100%0%0%20
   OpenprojectResponseException.php100%100%100%100%
   OpenprojectUnauthorizedUserException.php0%100%0%0%16
server/apps/integration_openproject/lib/Listener
   BeforeGroupDeletedListener.php0%100%0%0%45, 53–54, 57–60
   BeforeNodeInsideOpenProjectGroupfilderChangedListener.php0%100%0%0%37–39, 43–48, 50–55, 57, 59, 63
   BeforeUserDeletedListener.php0%100%0%0%45, 52–53, 55–58
   LoadSidebarScript.php0%100%0%0%101, 103–105, 107, 109, 111–112, 114–115, 117, 119, 72–78, 80–81, 83–84, 86–87, 93–94, 96–97, 99
   UserChangedListener.php0%100%0%0%49, 56–57, 60–64
server/apps/integration_openproject/lib/Migration
   Version2001Date20221213083550.php0%100%0%0%47, 57, 60, 63, 67, 70, 73, 77–79, 81
   Version2310Date20230116153411.php0%100%0%0%46, 49–52, 54–56, 60, 64, 68, 72, 76, 81–82, 84
server/apps/integration_openproject/lib/Search
   OpenProjectSearchProvider.php0%100%0%0%102, 109–110, 113–118, 120–121, 123–125, 128–129, 131–132, 136–141, 147–148, 150, 159–163, 171–179, 195–202, 211–216, 71–75, 82, 89, 97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
server/apps/integration_openproject/lib/Service
   DatabaseService.php43.90%100%60%41.67%125–128, 131, 80–87, 89–93, 95–97
   DirectDownloadService.php88%100%100%86.96%65–66, 68
   DirectUploadService.php54.55%100%66.67%52.63%112, 118, 79–82, 84, 89, 91
   OauthService.php0%100%0%0%37–38, 47–53, 55, 64–67, 78–85, 95–99
   OpenProjectAPIService.php73.94%100%75%73.84%167–171, 343–344, 346, 360–361, 370, 374, 395, 483–484, 491, 494–497, 499, 505, 509–511, 531, 540–543, 547–549, 554–556, 559–561, 563, 566–567, 570, 736, 807, 837–838, 840, 842–843, 866, 870, 874–875, 878–881, 883–884, 886–887, 889–890, 898–905, 911, 935, 937, 940, 943, 949, 954, 958, 968, 970, 973, 975, 980, 982–985, 988
server/apps/integration_openproject/lib/Settings
   Admin.php0%100%0%0%32–34, 41–43, 46–50, 53, 58–59, 62, 64–65, 67, 71, 75
   AdminSection.php0%100%0%0%19–20, 29, 39, 48, 55
   Personal.php87.88%100%50%93.10%94, 98
   PersonalSection.php0%100%0%0%19–20, 29,

@SagarGi SagarGi self-assigned this Jun 6, 2023
@@ -28,7 +28,7 @@ jobs:
phpVersion: 7.4
- nextcloudVersion: master
phpVersion: 7.4
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here running the jobs on ubuntu-20.04 does not give error disk quota exceeded. Could not dig the prime cause for it.

@individual-it individual-it marked this pull request as ready for review June 6, 2023 09:44
@SwikritiT SwikritiT merged commit 34da629 into master Jun 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the use_old_php_version_for_unittest branch June 6, 2023 09:54
@SagarGi SagarGi changed the title Installed additional module, authenticated docker hub for more image pull [WP#48443]Installed additional module, authenticated docker hub for more image pull Jun 7, 2023
@SagarGi SagarGi changed the title [WP#48443]Installed additional module, authenticated docker hub for more image pull [OP#48443]Installed additional module, authenticated docker hub for more image pull Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants