-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OP#48443]Installed additional module, authenticated docker hub for more image pull #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagarGi
force-pushed
the
use_old_php_version_for_unittest
branch
28 times, most recently
from
June 2, 2023 06:03
89dd40a
to
529775f
Compare
SagarGi
changed the title
Use old php version for unit test
Installed additional module, authenticated docker hub for more image pull
Jun 2, 2023
SagarGi
force-pushed
the
use_old_php_version_for_unittest
branch
from
June 2, 2023 06:24
529775f
to
b48c7be
Compare
SagarGi
force-pushed
the
use_old_php_version_for_unittest
branch
15 times, most recently
from
June 6, 2023 08:33
7eff342
to
3c66e2f
Compare
SagarGi
force-pushed
the
use_old_php_version_for_unittest
branch
from
June 6, 2023 08:42
3c66e2f
to
97396fe
Compare
JS Code CoverageCoverage after merging use_old_php_version_for_unittest into master will be
Coverage Report
|
SagarGi
commented
Jun 6, 2023
@@ -28,7 +28,7 @@ jobs: | |||
phpVersion: 7.4 | |||
- nextcloudVersion: master | |||
phpVersion: 7.4 | |||
runs-on: ubuntu-latest | |||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here running the jobs on ubuntu-20.04
does not give error disk quota exceeded
. Could not dig the prime cause for it.
individual-it
approved these changes
Jun 6, 2023
SwikritiT
approved these changes
Jun 6, 2023
SagarGi
changed the title
Installed additional module, authenticated docker hub for more image pull
[WP#48443]Installed additional module, authenticated docker hub for more image pull
Jun 7, 2023
SagarGi
changed the title
[WP#48443]Installed additional module, authenticated docker hub for more image pull
[OP#48443]Installed additional module, authenticated docker hub for more image pull
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.The php gd extension is required for the CI and also extension sqlite3 is need in order to install nextcloud in sqlite to run unit tests. This PR adds those modules. Other wise CI gives error like below:
Also added
sqlite3
extension to be able to install thenextcloud
with itAlso adds new step to set up .NET core required to execute the
Convert PHP cobertura coverage to lcov
step in CIBump
ubuntu
to20.04
since it exists with errordisk quota exceeded
.Related work package: https://community.openproject.org/projects/nextcloud-integration/work_packages/48443