Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OP#48106] link previews UI implementation #428

Merged

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Jun 26, 2023

Related workpackage: https://community.openproject.org/projects/nextcloud-integration/work_packages/48106/activity

The smart picker

Screenshot from 2023-06-27 14-45-32

The link previews are as so

Talk

Screenshot from 2023-06-27 14-38-20

Text

Screenshot from 2023-06-27 14-38-47

Preview for user unauthenticated to openproject

Screenshot from 2023-07-04 15-21-52

Preview for user authenticated to openproject

Screenshot from 2023-07-04 15-22-00

Prerequisite for testing

  1. Setup openproject to work with https https://www.openproject.org/docs/development/localhost-ssl/
  2. Enable nextcloud talk app or text app
  3. Enable global search for workpackages
  4. the smart picker can be triggered by / command in talk chat or text editor

Note: you might need to import the self signed certificate to nextcloud which can be done using

sudo -u www-data ./occ security:certificates:import <path-to-certificate>

@SwikritiT SwikritiT force-pushed the enh/noid/smart-picker-and-link-previews-ui-implementation branch from c53c356 to 08e30c7 Compare June 26, 2023 11:00
@SwikritiT SwikritiT changed the title link previews UI implementation [OP#48106] link previews UI implementation Jun 26, 2023
@SwikritiT SwikritiT force-pushed the enh/noid/smart-picker-and-link-previews-ui-implementation branch from 44b52bf to eb8e3b0 Compare June 27, 2023 08:33
@SwikritiT SwikritiT self-assigned this Jun 27, 2023
@SwikritiT SwikritiT force-pushed the enh/noid/smart-picker-and-link-previews-ui-implementation branch from eb8e3b0 to d7c1621 Compare June 27, 2023 09:15
@SwikritiT SwikritiT force-pushed the enh/noid/smart-picker-and-link-previews-ui-implementation branch from d7c1621 to 0d71ee0 Compare July 4, 2023 09:37
@SwikritiT SwikritiT marked this pull request as ready for review July 4, 2023 09:41
@SwikritiT SwikritiT force-pushed the enh/noid/smart-picker-and-link-previews-ui-implementation branch from 6bc5655 to e23bcf6 Compare July 5, 2023 08:28
@SwikritiT SwikritiT force-pushed the enh/noid/smart-picker-and-link-previews-ui-implementation branch from e23bcf6 to 98be22b Compare July 10, 2023 03:51
Copy link
Collaborator

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@SwikritiT SwikritiT force-pushed the enh/noid/smart-picker-and-link-previews-ui-implementation branch from 98be22b to 569da1c Compare July 12, 2023 03:54
@github-actions
Copy link

JS Code Coverage

Coverage after merging enh/noid/smart-picker-and-link-previews-ui-implementation into master will be
90.27%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   bootstrap.js0%0%0%0%1, 1–7
   dashboard.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   fileActions.js0%0%0%0%1, 1, 10–17, 2–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–66, 7–9
   reference.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–43, 5–9
   utils.js63.64%33.33%50%66%10–14, 17–26, 6–9
src/components
   AdminSettings.vue99.27%95.35%84.62%99.91%1, 1, 1, 1, 1
   OAuthConnectButton.vue99.17%87.50%100%100%1
   PersonalSettings.vue98.87%93.33%85.71%100%1
src/components/admin
   FieldValue.vue97.12%83.33%100%98.89%1, 23, 23
   FormHeading.vue98.05%81.82%100%99.29%1, 29, 29
   ProjectFolderError.vue96.83%80%100%98.21%1, 1
   TextInput.vue99.25%95%88.89%100%1
src/components/icons
   ClippyIcon.vue93.18%50%50%97.50%1, 1
src/components/settings
   CheckBox.vue92.45%80%66.67%97.62%1, 1
   SettingsTitle.vue94.74%50%100%97.14%1, 1
src/components/tab
   EmptyContent.vue97.96%84.62%100%99.24%1, 29, 29
   SearchInput.vue99.57%88.89%100%100%1
   WorkPackage.vue98.36%40%100%99.33%1, 1, 1, 43, 43
src/utils
   workpackageHelper.js94.21%88%100%95.65%17–19, 48, 48–50
src/views
   Dashboard.vue98.04%62.50%60%99.66%1, 1, 1, 1
   ProjectsTab.vue99.74%93.75%100%100%23
   WorkPackageReferenceWidget.vue0%0%0%0%1, 1, 10, 100–109, 11, 110–119, 12, 120–129, 13, 130–132, 14–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99

@github-actions
Copy link

PHP Code Coverage

Coverage after merging enh/noid/smart-picker-and-link-previews-ui-implementation into master will be
57.01%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
server/apps/integration_openproject/lib/AppInfo
   Application.php11.43%100%25%9.68%100–102, 106–109, 111, 115–120, 131, 135, 68–69, 72, 76, 79, 83, 85, 89, 94, 96–98
server/apps/integration_openproject/lib/BackgroundJob
   RemoveExpiredDirectUploadTokens.php0%100%0%0%42, 44–46, 55–56
server/apps/integration_openproject/lib/Controller
   ConfigController.php66.40%100%50%67.36%134, 151–152, 154, 156–158, 160–161, 166–167, 169, 219, 280, 369–370, 373–374, 504–507, 509–510, 513, 521, 532, 546–548, 563–567, 569–570, 572–575, 577–579, 597–602, 604–605, 607–609, 612, 614–617, 619–621, 635, 644–647, 649–652, 662–667
   DirectDownloadController.php0%100%0%0%36–38, 53–55, 57, 60–61
   DirectUploadController.php71.43%100%100%70.43%131–132, 177, 190, 194–197, 199, 209, 216, 232–234, 236–237, 240–242, 248, 250, 255–256, 263–264, 267–268, 271–272, 288–289, 309, 314, 320
   FilesController.php78.86%100%100%77.59%168, 220–221, 272, 278–282, 285–287, 289, 291, 302–304, 307–308, 310–311, 315–318, 321
   OpenProjectAPIController.php83.82%100%73.33%84.66%136, 171, 188–189, 193, 197, 199–204, 206, 215–216, 219, 221, 223–226, 228–229, 234, 253, 278, 537, 539, 95
server/apps/integration_openproject/lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101–102, 104–108, 116, 123–124, 126, 128–129, 131–132, 134, 137–138, 140–141, 143, 69–73, 80, 87, 94
server/apps/integration_openproject/lib/Exception
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectFileNotUploadedException.php100%100%100%100%
   OpenprojectGroupfolderSetupConflictException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
   OpenprojectUnauthorizedUserException.php0%100%0%0%16
server/apps/integration_openproject/lib/Listener
   BeforeGroupDeletedListener.php0%100%0%0%48, 56–57, 60–63
   BeforeNodeInsideOpenProjectGroupfilderChangedListener.php0%100%0%0%40–42, 46–51, 53–58, 60, 62, 66
   BeforeUserDeletedListener.php0%100%0%0%48, 55–56, 58–61
   LoadSidebarScript.php0%100%0%0%100, 102, 104, 106–108, 110, 112, 114–115, 117–118, 120, 122, 75–81, 83–84, 86–87, 89–90, 96–97, 99
   OpenProjectReferenceListener.php0%100%0%0%37–38, 41
   UserChangedListener.php0%100%0%0%52, 59–60, 63–68
server/apps/integration_openproject/lib/Migration
   Version2001Date20221213083550.php0%100%0%0%47, 57, 60, 63, 67, 70, 73, 77–79, 81
   Version2310Date20230116153411.php0%100%0%0%46, 49–52, 54–56, 60, 64, 68, 72, 76, 81–82, 84
   Version2400Date20230504144300.php0%100%0%0%47, 57, 60
server/apps/integration_openproject/lib/Reference
   WorkPackageReferenceProvider.php0%100%0%0%110–113, 116, 123–126, 129–131, 134, 141–144, 146, 148–150, 152, 154, 156, 160, 169, 177–178, 186, 53, 60, 67, 74–75, 83–84, 86–87, 90, 92–93, 95, 97
server/apps/integration_openproject/lib/Search
   OpenProjectSearchProvider.php0%100%0%0%103–104, 107–112, 114–115, 117–119, 122–123, 125–126, 130–135, 141–142, 144, 66–69, 76, 83, 91, 93, 96
   OpenProjectSearchResultEntry.php100%100%100%100%
server/apps/integration_openproject/lib/Service
   DatabaseService.php43.90%100%60%41.67%125–128, 131, 80–87, 89–93, 95–97
   DirectDownloadService.php88%100%100%86.96%65–66, 68
   DirectUploadService.php54.55%100%66.67%52.63%112, 118, 79–82, 84, 89, 91
   OauthService.php0%100%0%0%37–38, 47–53, 55, 64–67, 78–85, 95–99
   OpenProjectAPIService.php69.20%100%65.85%69.53%1000, 1006, 1011, 1015, 1025, 1027, 1030, 1032, 1131–1133, 1143, 1153–1159, 1167–1171, 1179–1186, 1203–1210, 1219–1224, 180–184, 255, 364–365, 367, 381–382, 391, 395, 416, 504–505, 512, 515–518, 520, 526, 530–532, 552, 562–565, 569–570,

@SwikritiT SwikritiT merged commit 0e78dab into master Jul 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/smart-picker-and-link-previews-ui-implementation branch July 12, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants