-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OP#48106] link previews UI implementation #428
Merged
SwikritiT
merged 1 commit into
master
from
enh/noid/smart-picker-and-link-previews-ui-implementation
Jul 12, 2023
Merged
[OP#48106] link previews UI implementation #428
SwikritiT
merged 1 commit into
master
from
enh/noid/smart-picker-and-link-previews-ui-implementation
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
force-pushed
the
enh/noid/smart-picker-and-link-previews-ui-implementation
branch
from
June 26, 2023 11:00
c53c356
to
08e30c7
Compare
SwikritiT
changed the title
link previews UI implementation
[OP#48106] link previews UI implementation
Jun 26, 2023
SwikritiT
force-pushed
the
enh/noid/smart-picker-and-link-previews-ui-implementation
branch
from
June 27, 2023 08:33
44b52bf
to
eb8e3b0
Compare
SwikritiT
commented
Jun 27, 2023
SwikritiT
force-pushed
the
enh/noid/smart-picker-and-link-previews-ui-implementation
branch
from
June 27, 2023 09:15
eb8e3b0
to
d7c1621
Compare
SwikritiT
force-pushed
the
enh/noid/smart-picker-and-link-previews-ui-implementation
branch
from
July 4, 2023 09:37
d7c1621
to
0d71ee0
Compare
SwikritiT
force-pushed
the
enh/noid/smart-picker-and-link-previews-ui-implementation
branch
from
July 5, 2023 08:28
6bc5655
to
e23bcf6
Compare
individual-it
approved these changes
Jul 7, 2023
SwikritiT
force-pushed
the
enh/noid/smart-picker-and-link-previews-ui-implementation
branch
from
July 10, 2023 03:51
e23bcf6
to
98be22b
Compare
SagarGi
reviewed
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
SwikritiT
force-pushed
the
enh/noid/smart-picker-and-link-previews-ui-implementation
branch
from
July 12, 2023 03:54
98be22b
to
569da1c
Compare
JS Code CoverageCoverage after merging enh/noid/smart-picker-and-link-previews-ui-implementation into master will be
Coverage Report
|
delete-merged-branch
bot
deleted the
enh/noid/smart-picker-and-link-previews-ui-implementation
branch
July 12, 2023 09:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related workpackage: https://community.openproject.org/projects/nextcloud-integration/work_packages/48106/activity
The smart picker
The link previews are as so
Talk
Text
Preview for user unauthenticated to openproject
Preview for user authenticated to openproject
Prerequisite for testing
https
https://www.openproject.org/docs/development/localhost-ssl//
command in talk chat or text editor