-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#49133] throw better error message when admin tries to delete/disable OP user/group #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
commented
Jul 14, 2023
wielinde
reviewed
Jul 14, 2023
SwikritiT
force-pushed
the
fix/error-message-op-user-deletion
branch
from
July 17, 2023 06:06
b9ec884
to
de126c8
Compare
SwikritiT
force-pushed
the
fix/error-message-op-user-deletion
branch
from
July 21, 2023 07:01
dee01f9
to
475f0d0
Compare
SagarGi
reviewed
Jul 21, 2023
SagarGi
reviewed
Jul 21, 2023
SagarGi
reviewed
Jul 21, 2023
SagarGi
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…/group Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
SwikritiT
force-pushed
the
fix/error-message-op-user-deletion
branch
from
July 31, 2023 03:57
360e208
to
f88f2fa
Compare
JS Code CoverageCoverage after merging fix/error-message-op-user-deletion into master will be
Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related workpackage[OP#49133]: https://community.openproject.org/work_packages/49133
We are protecting user/group Openproject from being deleted/disabled but the error message displayed is
An error occurred during the request. Unable to proceed
which is vague. So show proper error messages so that it's known that this user is protected.In this PR, we let the user know that the OP user/group is protected and redirect them towards open project troubleshooting docs for further information
The error message displayed now is