-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#50431] Project folders setup: add special characters to generated passwords #508
[#50431] Project folders setup: add special characters to generated passwords #508
Conversation
https://community.openproject.org/work_packages/50431 Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
JS Code CoverageCoverage after merging bug/50431-project-folders-setup-password-is-missing into release/2.4 will be
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that an app password also has to meet those requirements.
Please check if there are more requirements that the password policy can enforce and we would not meet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes: https://community.openproject.org/work_packages/50431
As the password that we generated for project folders didn't contain the special characters in case the nextcloud instance has a password policy setup enforcing special characters, an error is shown while setting up the project folders. This PR adds special characters in the password to prevent that from happening