-
Notifications
You must be signed in to change notification settings - Fork 19
fix: use public Node API instead of internal View methods #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
14ef661 to
ee79dfa
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
ee79dfa to
d14ec44
Compare
3cdf08d to
71a8c46
Compare
individual-it
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and to prove it works we have an API test that still passes: https://github.com/nextcloud/integration_openproject/blob/master/tests/acceptance/features/api/getFileinfoByFileIDAPI.feature#L1355
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
71a8c46 to
8a2cd47
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Description
Following recent Nextcloud changes (#55574) where the View class marked as @internal, this PR replaces
DirectUploadControllerto use the recommendedNode APIinstead.A similar approach is used in other apps like files_zip
Documentation for the Node API used is available at:
https://docs.nextcloud.com/server/stable/developer_manual/basics/storage/filesystem.html#direct-storage-access
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile