-
Notifications
You must be signed in to change notification settings - Fork 19
fix: mock client in php-unit test #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
ea2c266 to
9455f8b
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
fce89cf to
37c8584
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
37c8584 to
c69241a
Compare
1f87376 to
9186d24
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
9186d24 to
bb500cc
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
a12b4c8 to
bd54fa1
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
4f1a5e7 to
a7905a6
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
a7905a6 to
9ec00d0
Compare
Signed-off-by: Sawjan Gurung <saw.jan.grg3e@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Description
Php unit tests were failing because Nextcloud 31+ changed( PR ) how clients work i.e Client constructor requires 6 parameters including ServerVersion, but our tests were still using the old way(without ServerVersion).
So, instead of creating complicated version-specific HTTP clients, here is simplified it to just mock the service that creates clients.
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile