Skip to content

Conversation

@nabim777
Copy link
Collaborator

@nabim777 nabim777 commented Nov 10, 2025

Description

Php unit tests were failing because Nextcloud 31+ changed( PR ) how clients work i.e Client constructor requires 6 parameters including ServerVersion, but our tests were still using the old way(without ServerVersion).
So, instead of creating complicated version-specific HTTP clients, here is simplified it to just mock the service that creates clients.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777 nabim777 self-assigned this Nov 10, 2025
@nabim777 nabim777 force-pushed the ci/fix-error branch 3 times, most recently from ea2c266 to 9455f8b Compare November 10, 2025 09:05
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777 nabim777 force-pushed the ci/fix-error branch 2 times, most recently from fce89cf to 37c8584 Compare November 11, 2025 04:20
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777 nabim777 changed the title Fix Client constructor test compatibility fix: mock client in unit test Nov 11, 2025
@nabim777 nabim777 changed the title fix: mock client in unit test fix: mock client in php-unit test Nov 11, 2025
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777 nabim777 requested a review from saw-jan November 18, 2025 09:25
@nabim777 nabim777 force-pushed the ci/fix-error branch 2 times, most recently from a12b4c8 to bd54fa1 Compare November 18, 2025 09:48
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777 nabim777 force-pushed the ci/fix-error branch 2 times, most recently from 4f1a5e7 to a7905a6 Compare November 19, 2025 09:10
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Signed-off-by: Sawjan Gurung <saw.jan.grg3e@gmail.com>
@nabim777 nabim777 merged commit d73c096 into master Nov 19, 2025
12 checks passed
@nabim777 nabim777 deleted the ci/fix-error branch November 19, 2025 09:48
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants