Compatibility for NC26+ and PHP 8.0 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
force-pushed
the
feat/support-nc26-php8-with-iplib
branch
20 times, most recently
from
be96362
to
b6573cf
Compare
Altahrim
force-pushed
the
feat/support-nc26-php8-with-iplib
branch
6 times, most recently
from
59b6c6f
to
0f009fd
Compare
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
feat/support-nc26-php8-with-iplib
branch
from
0f009fd
to
acd1670
Compare
come-nc
approved these changes
Aug 7, 2023
nickvergessen
requested changes
Aug 7, 2023
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
feat/support-nc26-php8-with-iplib
branch
2 times, most recently
from
26c3856
to
39e4067
Compare
Uses `mlocati/ip-lib` for IP check Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
feat/support-nc26-php8-with-iplib
branch
7 times, most recently
from
c42dadd
to
91eebe6
Compare
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
feat/support-nc26-php8-with-iplib
branch
from
91eebe6
to
97ce05f
Compare
nickvergessen
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
psalm,cs-fixer,phpunit)/index.php/login?redirect_url=/index.php/settings/admin/security