-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LogIterator duplicates and drops log entries #1235
Conversation
This conditional here logreader/lib/Log/LogIterator.php Lines 93 to 97 in 0a97cbc
could possibly be replaced by just seeking one byte before EOF to cut off the final newline: In LogIterator::rewind() : fseek($this->handle, -1, SEEK_END);
Not sure how reliable this assumption is though. |
Signed-off-by: Jörg Mechnich <joerg.mechnich@gmail.com>
0a97cbc
to
23f4b41
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Added some changes to make the tests pass, please verify that things are still working as expected for you.
I think the current approach is more reliable |
Looks good, thanks! 👍 |
/backport to stable29 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Fixes #1236.