Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Adjust server version to test against #886

Merged
merged 1 commit into from
Jun 7, 2023
Merged

[stable25] Adjust server version to test against #886

merged 1 commit into from
Jun 7, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 6, 2023

Set server version to stable25 instead of master for phpunit tests of the stable25 branch.

@susnux
fix: Test against stable25 server version
7bc980b 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux mentioned this pull request Jun 6, 2023
Merged
@susnux susnux requested a review from Antreesy June 7, 2023 09:46
Antreesy
Antreesy approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legal, but don't we need to test against other PHP versions as well in these places, like for sqlite: php-versions: ['7.4', '8.0', '8.1'] ?

@susnux
Copy link
Contributor Author

susnux commented Jun 7, 2023

Seems legal, but don't we need to test against other PHP versions as well in these places, like for sqlite: php-versions: ['7.4', '8.0', '8.1'] ?

I think this is done because sqlite is quite cheap (performance) so all supported PHP versions are tested and for the other database systems only the recommended version is tested. At least that is how most apps are tested.

@susnux susnux merged commit 64708fa into stable25 Jun 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/stable25-adjust-testing-version branch June 7, 2023 11:33
@blizzz blizzz mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @Antreesy