fix: bring back too many recipients check #3289
psalm-matrix.yml
on: pull_request
Matrix: static-analysis
static-psalm-analysis-summary
7s
Annotations
41 errors
UndefinedClass:
lib/AppInfo/Application.php#L136
lib/AppInfo/Application.php:136:35: UndefinedClass: Class, interface or enum named OCA\Mail\Events\OutboxMessageStatusChangeEvent does not exist (see https://psalm.dev/019)
|
UndefinedClass:
lib/AppInfo/Application.php#L136
lib/AppInfo/Application.php:136:74: UndefinedClass: Class, interface or enum named OCA\Mail\Listener\OutboxStatusChangeListener does not exist (see https://psalm.dev/019)
|
InvalidArgument:
lib/Send/Chain.php#L56
lib/Send/Chain.php:56:32: InvalidArgument: Argument 1 of OCA\Mail\Db\MessageMapper::update expects OCA\Mail\Db\Message, but OCA\Mail\Db\LocalMessage provided (see https://psalm.dev/004)
|
ImplicitToStringCast:
lib/Service/AntiSpamService.php#L145
lib/Service/AntiSpamService.php:145:31: ImplicitToStringCast: Argument 1 of OCA\Mail\Exception\ServiceException::__construct expects string, but OCA\Mail\Exception\ServiceException provided with a __toString method (see https://psalm.dev/060)
|
ImplicitToStringCast:
lib/Service/MailTransmission.php#L134
lib/Service/MailTransmission.php:134:25: ImplicitToStringCast: Argument 1 of Psr\Log\LoggerInterface::error expects string, but OCA\Mail\Exception\ServiceException provided with a __toString method (see https://psalm.dev/060)
|
ImplicitToStringCast:
lib/Service/MailTransmission.php#L146
lib/Service/MailTransmission.php:146:25: ImplicitToStringCast: Argument 1 of Psr\Log\LoggerInterface::error expects string, but Horde_Mime_Exception provided with a __toString method (see https://psalm.dev/060)
|
TooManyArguments:
lib/Service/MailTransmission.php#L175
lib/Service/MailTransmission.php:175:32: TooManyArguments: Too many arguments for method OCA\Mail\Service\TransmissionService::handleattachment - saw 3 (see https://psalm.dev/026)
|
MismatchingDocblockReturnType:
lib/Service/RecipientsService.php#L46
lib/Service/RecipientsService.php:46:13: MismatchingDocblockReturnType: Docblock has incorrect return type 'OCA\Mail\Db\LocalMessage', should be 'void' (see https://psalm.dev/142)
|
InvalidReturnType:
lib/Service/RecipientsService.php#L46
lib/Service/RecipientsService.php:46:13: InvalidReturnType: The declared return type 'OCA\Mail\Db\LocalMessage' for OCA\Mail\Service\RecipientsService::checkNumberOfRecipients is incorrect, got 'void' (see https://psalm.dev/011)
|
static-psalm-analysis dev-stable27
Process completed with exit code 2.
|
UndefinedClass:
lib/AppInfo/Application.php#L136
lib/AppInfo/Application.php:136:35: UndefinedClass: Class, interface or enum named OCA\Mail\Events\OutboxMessageStatusChangeEvent does not exist (see https://psalm.dev/019)
|
UndefinedClass:
lib/AppInfo/Application.php#L136
lib/AppInfo/Application.php:136:74: UndefinedClass: Class, interface or enum named OCA\Mail\Listener\OutboxStatusChangeListener does not exist (see https://psalm.dev/019)
|
InvalidArgument:
lib/Send/Chain.php#L56
lib/Send/Chain.php:56:32: InvalidArgument: Argument 1 of OCA\Mail\Db\MessageMapper::update expects OCA\Mail\Db\Message, but OCA\Mail\Db\LocalMessage provided (see https://psalm.dev/004)
|
ImplicitToStringCast:
lib/Service/AntiSpamService.php#L145
lib/Service/AntiSpamService.php:145:31: ImplicitToStringCast: Argument 1 of OCA\Mail\Exception\ServiceException::__construct expects string, but OCA\Mail\Exception\ServiceException provided with a __toString method (see https://psalm.dev/060)
|
ImplicitToStringCast:
lib/Service/MailTransmission.php#L134
lib/Service/MailTransmission.php:134:25: ImplicitToStringCast: Argument 1 of Psr\Log\LoggerInterface::error expects string, but OCA\Mail\Exception\ServiceException provided with a __toString method (see https://psalm.dev/060)
|
ImplicitToStringCast:
lib/Service/MailTransmission.php#L146
lib/Service/MailTransmission.php:146:25: ImplicitToStringCast: Argument 1 of Psr\Log\LoggerInterface::error expects string, but Horde_Mime_Exception provided with a __toString method (see https://psalm.dev/060)
|
TooManyArguments:
lib/Service/MailTransmission.php#L175
lib/Service/MailTransmission.php:175:32: TooManyArguments: Too many arguments for method OCA\Mail\Service\TransmissionService::handleattachment - saw 3 (see https://psalm.dev/026)
|
MismatchingDocblockReturnType:
lib/Service/RecipientsService.php#L46
lib/Service/RecipientsService.php:46:13: MismatchingDocblockReturnType: Docblock has incorrect return type 'OCA\Mail\Db\LocalMessage', should be 'void' (see https://psalm.dev/142)
|
InvalidReturnType:
lib/Service/RecipientsService.php#L46
lib/Service/RecipientsService.php:46:13: InvalidReturnType: The declared return type 'OCA\Mail\Db\LocalMessage' for OCA\Mail\Service\RecipientsService::checkNumberOfRecipients is incorrect, got 'void' (see https://psalm.dev/011)
|
static-psalm-analysis dev-stable28
Process completed with exit code 2.
|
UndefinedClass:
lib/AppInfo/Application.php#L136
lib/AppInfo/Application.php:136:35: UndefinedClass: Class, interface or enum named OCA\Mail\Events\OutboxMessageStatusChangeEvent does not exist (see https://psalm.dev/019)
|
UndefinedClass:
lib/AppInfo/Application.php#L136
lib/AppInfo/Application.php:136:74: UndefinedClass: Class, interface or enum named OCA\Mail\Listener\OutboxStatusChangeListener does not exist (see https://psalm.dev/019)
|
InvalidArgument:
lib/Send/Chain.php#L56
lib/Send/Chain.php:56:32: InvalidArgument: Argument 1 of OCA\Mail\Db\MessageMapper::update expects OCA\Mail\Db\Message, but OCA\Mail\Db\LocalMessage provided (see https://psalm.dev/004)
|
ImplicitToStringCast:
lib/Service/AntiSpamService.php#L145
lib/Service/AntiSpamService.php:145:31: ImplicitToStringCast: Argument 1 of OCA\Mail\Exception\ServiceException::__construct expects string, but OCA\Mail\Exception\ServiceException provided with a __toString method (see https://psalm.dev/060)
|
ImplicitToStringCast:
lib/Service/MailTransmission.php#L134
lib/Service/MailTransmission.php:134:25: ImplicitToStringCast: Argument 1 of Psr\Log\LoggerInterface::error expects string, but OCA\Mail\Exception\ServiceException provided with a __toString method (see https://psalm.dev/060)
|
ImplicitToStringCast:
lib/Service/MailTransmission.php#L146
lib/Service/MailTransmission.php:146:25: ImplicitToStringCast: Argument 1 of Psr\Log\LoggerInterface::error expects string, but Horde_Mime_Exception provided with a __toString method (see https://psalm.dev/060)
|
TooManyArguments:
lib/Service/MailTransmission.php#L175
lib/Service/MailTransmission.php:175:32: TooManyArguments: Too many arguments for method OCA\Mail\Service\TransmissionService::handleattachment - saw 3 (see https://psalm.dev/026)
|
MismatchingDocblockReturnType:
lib/Service/RecipientsService.php#L46
lib/Service/RecipientsService.php:46:13: MismatchingDocblockReturnType: Docblock has incorrect return type 'OCA\Mail\Db\LocalMessage', should be 'void' (see https://psalm.dev/142)
|
InvalidReturnType:
lib/Service/RecipientsService.php#L46
lib/Service/RecipientsService.php:46:13: InvalidReturnType: The declared return type 'OCA\Mail\Db\LocalMessage' for OCA\Mail\Service\RecipientsService::checkNumberOfRecipients is incorrect, got 'void' (see https://psalm.dev/011)
|
static-psalm-analysis dev-master
Process completed with exit code 2.
|
UndefinedClass:
lib/AppInfo/Application.php#L136
lib/AppInfo/Application.php:136:35: UndefinedClass: Class, interface or enum named OCA\Mail\Events\OutboxMessageStatusChangeEvent does not exist (see https://psalm.dev/019)
|
UndefinedClass:
lib/AppInfo/Application.php#L136
lib/AppInfo/Application.php:136:74: UndefinedClass: Class, interface or enum named OCA\Mail\Listener\OutboxStatusChangeListener does not exist (see https://psalm.dev/019)
|
InvalidArgument:
lib/Send/Chain.php#L56
lib/Send/Chain.php:56:32: InvalidArgument: Argument 1 of OCA\Mail\Db\MessageMapper::update expects OCA\Mail\Db\Message, but OCA\Mail\Db\LocalMessage provided (see https://psalm.dev/004)
|
ImplicitToStringCast:
lib/Service/AntiSpamService.php#L145
lib/Service/AntiSpamService.php:145:31: ImplicitToStringCast: Argument 1 of OCA\Mail\Exception\ServiceException::__construct expects string, but OCA\Mail\Exception\ServiceException provided with a __toString method (see https://psalm.dev/060)
|
ImplicitToStringCast:
lib/Service/MailTransmission.php#L134
lib/Service/MailTransmission.php:134:25: ImplicitToStringCast: Argument 1 of Psr\Log\LoggerInterface::error expects string, but OCA\Mail\Exception\ServiceException provided with a __toString method (see https://psalm.dev/060)
|
ImplicitToStringCast:
lib/Service/MailTransmission.php#L146
lib/Service/MailTransmission.php:146:25: ImplicitToStringCast: Argument 1 of Psr\Log\LoggerInterface::error expects string, but Horde_Mime_Exception provided with a __toString method (see https://psalm.dev/060)
|
TooManyArguments:
lib/Service/MailTransmission.php#L175
lib/Service/MailTransmission.php:175:32: TooManyArguments: Too many arguments for method OCA\Mail\Service\TransmissionService::handleattachment - saw 3 (see https://psalm.dev/026)
|
MismatchingDocblockReturnType:
lib/Service/RecipientsService.php#L46
lib/Service/RecipientsService.php:46:13: MismatchingDocblockReturnType: Docblock has incorrect return type 'OCA\Mail\Db\LocalMessage', should be 'void' (see https://psalm.dev/142)
|
InvalidReturnType:
lib/Service/RecipientsService.php#L46
lib/Service/RecipientsService.php:46:13: InvalidReturnType: The declared return type 'OCA\Mail\Db\LocalMessage' for OCA\Mail\Service\RecipientsService::checkNumberOfRecipients is incorrect, got 'void' (see https://psalm.dev/011)
|
static-psalm-analysis dev-stable26
Process completed with exit code 2.
|
static-psalm-analysis-summary
Process completed with exit code 1.
|