fixup! perf: reduce number of avatar requests

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
nextcloud · Dec 13, 2024 · 3a3867b · 3a3867b
1 parent f3abc06
commit 3a3867b
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/IMAP/PreviewEnhancer.php b/lib/IMAP/PreviewEnhancer.php
@@ -64,8 +64,9 @@ public function process(Account $account, Mailbox $mailbox, array $messages): ar
 		$needAnalyze = array_reduce($messages, function (array $carry, Message $message) {
 			if ($message->getStructureAnalyzed()) {
 				// Try fetching the avatar if it's not set
-				if ($message->getAvatar() === null && $message->getFrom()->first() !== null) {
-					$avatar = $this->avatarService->getAvatar($message->getFrom()->first()->getEmail(), $this->userId);
+				$from = $message->getFrom()->first() ;
+				if ($message->getAvatar() === null && $from !== null && $this->userId !== null) {
+					$avatar = $this->avatarService->getAvatar($from->getEmail(), $this->userId);
 					$message->setAvatar($avatar);
 				}
 				return $carry;
@@ -112,7 +113,8 @@ public function process(Account $account, Mailbox $mailbox, array $messages): ar
 			$message->setEncrypted($structureData->isEncrypted());
 			$message->setMentionsMe($structureData->getMentionsMe());
 
-			if ($message->getFrom()->first() !== null) {
+			$from = $message->getFrom()->first() ;
+			if ($message->getAvatar() === null && $from !== null && $this->userId !== null) {
 				$avatar = $this->avatarService->getAvatar($message->getFrom()->first()->getEmail(), $this->userId);
 				$message->setAvatar($avatar);