Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't edit email in outbox #10747

Open
pabzm opened this issue Feb 25, 2025 · 6 comments · May be fixed by #10754
Open

Can't edit email in outbox #10747

pabzm opened this issue Feb 25, 2025 · 6 comments · May be fixed by #10754
Assignees
@st3iny
Labels
2. developing bug regression

Comments

@pabzm
Copy link
Contributor

pabzm commented Feb 25, 2025

Steps to reproduce

I'm not sure what's causing it and so far couldn't reproduce it.

Expected behavior

If I click an email in the outbox, that wasn't sent due to a mail server error, it opens up in the editor.

Actual behavior

Nothing happens.

The webdev console shows this error:

TypeError: Cannot read properties of undefined (reading 'startComposerSession')
    at o.openModal (OutboxMessageListItem.vue:182:1)
    at dn (vue.runtime.esm.js:3033:30)
    at o.n (vue.runtime.esm.js:1832:20)
    at dn (vue.runtime.esm.js:3033:30)
    at e.$emit (vue.runtime.esm.js:3732:17)
    at o.onClick (NcListItem-P2z7dcyT.mjs:188:12)
    at click (NcListItem-P2z7dcyT.mjs:260:18)
    at dn (vue.runtime.esm.js:3033:30)
    at HTMLAnchorElement.n (vue.runtime.esm.js:1832:20)
    at Nr.s._wrapper (vue.runtime.esm.js:7500:35)
    at HTMLAnchorElement.r (sentry.js?v=3b32682e-1766:2:59691)

Mail app version

4.2.x (c.nc.com)

Nextcloud version

31.x (c.nc.com)

Mailserver or service

No response

Operating system

No response

PHP engine version

None

Nextcloud memory caching

No response

Web server

None

Database

None

Additional info

The error is from Vivaldi, a Chromium-based browser.

The problem is also present in Firefox, but its console shows a different error:

TypeError: this.mainStore is undefined
    openModal OutboxMessageListItem.vue:180
    VueJS 4
    onClick NcListItem-P2z7dcyT.mjs:188
    click NcListItem-P2z7dcyT.mjs:260
    VueJS 3
    NextJS 3
    VueJS 56
    fetchMessages Outbox.vue:103
    mounted Outbox.vue:81
    VueJS 18
    init vue-router.esm.js:3005
@st3iny st3iny self-assigned this Feb 25, 2025
@st3iny
Copy link
Member

st3iny commented Feb 26, 2025

This seems to be a general regression. I can't edit any message in the outbox.

@st3iny st3iny moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Feb 26, 2025
@st3iny
Copy link
Member

st3iny commented Feb 26, 2025

Is a regression from #10138 and #10477.

@st3iny st3iny linked a pull request Feb 26, 2025 that will close this issue
Open
@SebastianKrupinski
Copy link
Contributor

@st3iny @pabzm

Note: Two things to keep in mind with the outbox.

A. Automated messages can not be edited
B. In our DEV setups sometimes, when you run our tests the mail cache folder goes missing 'appdata_*/mail/mail_username'. This then causes an error when saving the contents and as a result might cause the issue above also. (this would only apply to messages with attachments tho)

@st3iny
Copy link
Member

st3iny commented Mar 4, 2025 •
edited
Loading

A. Automated messages can not be edited

@SebastianKrupinski This needs to be adjusted in my PR. How would I detect automated messages in the frontend? Is there are difference to other messages?

@SebastianKrupinski
Copy link
Contributor

@st3iny the easiest would be the lack of the editorBody field. Automated messages only have bodyPlain and/or bodyHtml

@jiriks74
Copy link

I just scheduled a message and I can't view it in the Outbox. When I click it # gets appended at the end of the current URL and nothing else happens. I can't even view the message to check whether everything's correct.

TypeError: this is undefined
TypeError: this.mainStore
TypeError: this is undefined
TypeError: this is undefined

appears in the console when I click the message. I use Firefox but Chromium doesn't work either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st3iny st3iny

Labels
2. developing bug regression
Projects
💌 📅 👥 Groupware team
Status: 🏗️ In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(composer): handling of plain and html bodies nextcloud/mail
4 participants
@st3iny @jiriks74 @pabzm @SebastianKrupinski