-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the main mail store to Pinia #10138
Conversation
78247eb
to
117f534
Compare
Not opening the PR yet as I still have the tests to migrate, but mail is useable (as far as it seems) |
Thanks so much for finishing the hardest parts Richard <3 |
needs a rebase, I wish you luck 🍀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be merged after branch off for stable4.1
Let's get this in |
4325bfd
to
1a5d97f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased, fixed conflicts and did some testing. I couldn't spot breakage.
1a5d97f
to
37381d8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com> Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud> # Conflicts: # src/components/ThreadEnvelope.vue # src/main.js # src/store/getters.js # src/store/index.js # src/store/mutations.js
1157541
to
34d7ce8
Compare
Oh shoot I'm sorry I didn't see that you wanted to finish this too @st3iny. I hope I didn't step on your feet here, everything should work now though, if you could just give a final review. |
No no, all good. I didn't do anything yet, just assigned myself to not forget about the PR. Thanks for the final rebase :) |
Fix #9237
This is going to be a big one...
Splitting stores into multiple files isn't very common in Pinia, but I really wanted to do so in this case, I took my inspiration for how to do it from these guys vuejs/pinia#802
A little overview of how this was done:
/store
for all the main mail store stuff[previous name]
+Mutation
dispatch
andcommit
usages in components to the correct Pinia usage