Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make multiselect menu more discoverable #10437

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Dec 2, 2024

fixes #10231

hovered
Screenshot from 2024-12-09 14-47-01

selected
Screenshot from 2024-12-09 14-49-25

To clarify

  • Should the checkmark be shown when the whole message is hovered, or when the avatar is hovered. Right now, the check mark is shown when the avatar is hovered.

@GretaD GretaD self-assigned this Dec 2, 2024
@GretaD GretaD marked this pull request as ready for review December 9, 2024 14:37
@GretaD GretaD requested a review from GVodyanov December 9, 2024 14:41
GVodyanov

This comment was marked as outdated.

@GretaD

This comment was marked as outdated.

@GretaD GretaD requested a review from GVodyanov December 9, 2024 15:10
@ChristophWurst
Copy link
Member

  • If all selected messages are read, there is a bulk Mark us unread. If at least one message is unread there is only a bulk Mark as read and no more Mark as unread.
  • There is no option to un-flag (un-star) a message (was not there before either)
  • Before it was possible to clear the selection. This feature is gone.
  • The expansion of the multiselect buttons makes the list move and at least on Firefox it's a bit jittery.
  • The hover state of the avatar of a selected message is identical to a message that is not selected. This means you get no click feedback when selecting a message until you leave the element again.

image

image

@GretaD
Copy link
Contributor Author

GretaD commented Dec 10, 2024

  • If all selected messages are read, there is a bulk Mark us unread. If at least one message is unread there is only a bulk Mark as read and no more Mark as unread.

Same scenario as favorite, unfavorite, explained below

  • There is no option to un-flag (un-star) a message (was not there before either)

It is there, i added it, but its one button that replaces each other. I just changed the icon for both states.
Screenshot from 2024-12-10 12-56-06
Screenshot from 2024-12-10 12-54-57

  • Before it was possible to clear the selection. This feature is gone.

You mean unselect, right? Its the second icon before last.

  • The expansion of the multiselect buttons makes the list move and at least on Firefox it's a bit jittery.

I'll test it there and fix it.

  • The hover state of the avatar of a selected message is identical to a message that is not selected. This means you get no click feedback when selecting a message until you leave the element again.

Yes, you need to select the avatar to actually select it. Selecting the message will open the message and should not select it( ✔️ as an action). These 2 actions should be split, you shouldnt select ✔️ a message when you only want to open it. So, i would say the hover state of the avatar should be the same, regardless of the state of the message, but, i can change it if you have an idea how.

I havent changed anything from the logic that was there. The behavior is the same as the original menu actions, i only added new icons. So, you propose to have both buttons out like in the mark as important example? When you have both actions selected, like for example, one favorite, and one not favorite, to show both icons, favorite and unfavorite?
In general, you dont expect people to do that.

image

@ChristophWurst
Copy link
Member

You mean unselect, right? Its the second icon before last.

Indeed.

Yes, you need to select the avatar to actually select it. Selecting the message will open the message and should not select it( ✔️ as an action). These 2 actions should be split, you shouldnt select ✔️ a message when you only want to open it. So, i would say the hover state of the avatar should be the same, regardless of the state of the message, but, i can change it if you have an idea how.

image

  1. Click the avatar to select a message
  2. Stay hovering

expected: dark checkmark
actual: light checkmark

@ChristophWurst
Copy link
Member

When you have both actions selected, like for example, one favorite, and one not favorite, to show both icons, favorite and unfavorite?
In general, you dont expect people to do that.

Yes. For Mark important/unimportant we also have both options

Copy link
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks and works great. Much better visually, I think.

image

@GretaD
Copy link
Contributor Author

GretaD commented Dec 10, 2024

not a bug :)

Screenshot from 2024-12-10 18-17-30

Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD force-pushed the feat/multiselect-menu-neustyle branch from 56fce0e to 085af79 Compare December 10, 2024 17:18
@GretaD GretaD enabled auto-merge December 10, 2024 17:19
@GretaD GretaD merged commit 791e126 into main Dec 10, 2024
34 checks passed
@GretaD GretaD deleted the feat/multiselect-menu-neustyle branch December 10, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More discoverable multi-select and bulk operations
4 participants