Remove php-mail transport #10516
Open
Remove php-mail transport #10516
+50
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/10066/remove-mail-transport
branch
from
d72fb07 to
cdc4916
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/10066/remove-mail-transport
branch
from
cdc4916 to
defab9a
Compare
SebastianKrupinski
approved these changes
Dec 17, 2024
|
I think this would qualify as a breaking change. We should do a major version bump for this. Do we want to have the setup check only as a first step and the actual removal a bit later like half a year? |
Yes. I will only backport the setup check. The removal is done for main / upcoming 4.2. I don’t mind keeping the code for a bit longer. However, I’d be surprised if we received many complaints about its removal. This kind of configuration is problematic: a user wouldn’t expect that, even with SMTP credentials set, the message is still delivered by the webserver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10066
I will backport the setup check with a different wording for stable4.1, stable4.0 and stable3.7.
For stable3.7 we need a conditional to register the setup check, or we skip the backport.