perf: skip message skeleton if it is cached #10750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
requested review from
ChristophWurst,
kesselb and
GretaD
as code owners
| let loadingTimeout | ||
| const isCached = !!this.mainStore.getMessage(this.envelope.databaseId) | ||
| if (!isCached) { | ||
| loadingTimeout = setTimeout(() => this.loading = Loading.Skeleton, 200) |
There was a problem hiding this comment.
eslint complains about the assignment as only expression of the array function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10749
Cache messages in the frontend directly. Only show the skeleton if message is not yet cached.
I also delayed the skeleton animation by 200 milliseconds as we also do HTTP level caching. To prevent flickering in case the message is not cached in the frontend but by the browser.
Screencasts
No browser cache + extremely slow connection
2025-02-25.21-33-00.mp4
Browser cache + normal connection (localhost)
2025-02-25.21-35-27.mp4