Add a cache for IMAP message in the database #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A feature where we can really see the benefit of this is #17. Not all servers have support for threads and then it gets very expensive to calculate them on demand. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChristophWurst
force-pushed
the
feature/message-cache
branch
from
7efdd58 to
2421fb3
Compare
2 tasks
This was referenced Nov 21, 2019
ChristophWurst
force-pushed
the
feature/message-cache
branch
from
92531d7 to
1b8a31a
Compare
This was referenced Dec 6, 2019
ChristophWurst
force-pushed
the
feature/message-cache
branch
5 times, most recently
from
fb17ad9 to
9a6cb9a
Compare
Co-authored-by: Roeland Jago Douma <roeland@famdouma.nl> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at> Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
ChristophWurst
force-pushed
the
feature/message-cache
branch
from
956da72 to
c287787
Compare
Closed
rullzer
approved these changes
Feb 3, 2020
Closed
This was referenced Feb 6, 2020
2 tasks
| @@ -60,7 +60,7 @@ public function find(string $userId, int $accountId): MailAccount { | |||
| } | |||
|
|
|||
| /** | |||
| * @param int $id | |||
This was referenced Sep 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I've been wanting to do for a long time. So here it is. Or, well, just a few modifications towards a new architecture I would like to have with this app.
The problem
Right now this app operates on IMAP directly. Hence the performance and capabilities completely depend on the IMAP server and its implementation. This means on many accounts pagination and search is slow because SORT is not supported. We use Horde's cache driver but it doesn't really yield and noticeable performance boost.
The proposal
In addition to mailboxes #1956 we should keep a copy of message information in the database. Then we can display mailboxes (folders) very quickly, paginate through them and search for strings. We can keep the database sync'ed with Horde's sync mechanism. This means the sync would shift from browser->Nextcloud to Nextcloud->IMAP. That implies that we need a new mechanism for the front-end, but I have some ideas and it should be fairly simple to work that out.
Eventually it will make this app similar to how desktop apps work (in regards to storing data locally).
A rough list of things to do
Don't sync the virtual flagged inbox to diskfine for now. can be improved laterA list of ideas for follow-up features
Concerns
Things that might be problematic are
cc @nextcloud/mail @rullzer for early input/feedback